dashboard/app: test form get

Author: tarasmadan

dashboard/app/static/coverage.js

@@ -17,24 +17,6 @@ function initUpdateForm(){
   $('#target-subsystem').val(curUrlParams.get('subsystem'));
   $('#target-manager').val(curUrlParams.get('manager'));
   $("#only-unique").prop("checked", curUrlParams.get('subsystem') == "1");
-
-  $(document).ready(function() {
-    $("#updateButton").click(function(event) {
-      event.preventDefault(); // don't submit the form
-
-      var period = $("#target-period").val();
-      var subsystem = $("#target-subsystem").val();
-      var manager = $("#target-manager").val();
-      var onlyUnique = $("#only-unique").prop("checked") ? "1" : "0";
-
-      var newLocation = new URL(window.location.href);
-      newLocation.searchParams.set("period", period);
-      newLocation.searchParams.set("subsystem", subsystem);
-      newLocation.searchParams.set("manager", manager);
-      newLocation.searchParams.set("unique-only", onlyUnique);
-      window.location.href = newLocation.toString();
-    });
-  });
 }
 
 $(document).ready(initUpdateForm);

pkg/cover/templates/heatmap.html

@@ -105,7 +105,7 @@
 
 {{ define "body" }}
   <div style="display:inline-block">
-    <form>
+    <form method="get">
       <div style="display:inline-block; vertical-align: top">
         <label for="target-period">Periods:</label>
         <br>
@@ -116,26 +116,26 @@
         <label for="only-unique">Only unique:</label>
       </div>
       <div style="display:inline-block; vertical-align: top">
-        <select id="target-period">
+        <select id="target-period" name="period">
           <option value="month">Month</option>
           <option value="day">Day</option>
         </select>
         <br>
-        <select id="target-subsystem">
+        <select id="target-subsystem" name="subsystem">
           <option value="">*</option>
           {{ range $ss := .Subsystems }}
             <option value="{{ $ss }}">{{ $ss }}</option>
           {{ end }}
         </select>
         <br>
-        <select id="target-manager">
+        <select id="target-manager" name="manager">
           <option value="">*</option>
           {{ range $manager := .Managers }}
             <option value="{{ $manager }}">{{ $manager }}</option>
           {{ end }}
         </select>
         <br>
-        <input type="checkbox" id="only-unique" disabled>
+        <input type="checkbox" id="only-unique" name="unique-only" disabled>
       </div>
       <br>
       <button id="updateButton">Update</button>