tools/syz-imagegen: accept filesystem descriptions as input #6320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't generate just the hard-coded list of filesystems, but also generate seeds for the externally supplied json description of a filesystem. Add a special syscall attribute to help syz-imagegen guess the actual filesystem name from the syz_mount_image variant name.
a-nogikh
force-pushed
the
features/extend-imagegen
branch
from
6e7b21f to
297ff27
Compare
Collaborator
Author
|
Pushed two more commits - the objective is to generate a subset of feature combinations (in case there would be too many of them) right in the tool. TODO: debug the algorithm, for some reason it now stops at 36 instead of the specified 64 seeds. |
a-nogikh
force-pushed
the
features/extend-imagegen
branch
from
297ff27 to
e5527e9
Compare
Introduce a new Filesystem parameter - the maximum number of resulting seeds. If the total number of flag combinations exceeds this number, switch to generating a covering array (that is, make sure that all flag value pairs are covered, or at least as many of them as possible).
Transform the hard-coded list of feature combinations in to individual groups of features.
a-nogikh
force-pushed
the
features/extend-imagegen
branch
from
e5527e9 to
894d86f
Compare
Collaborator
Author
Okay, that was not a bug, but rather a feature :) If we only cover all pairs of feature values, we don't need too many seeds. I've adjusted the code to aim to cover all triples once all pairs are covered, now it can generate more seeds. |
dvyukov
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't generate just the hard-coded list of filesystems, but also generate seeds for the externally supplied json description of a filesystem.
Add a special syscall attribute to help syz-imagegen guess the actual filesystem name from the syz_mount_image variant name.