Skip to content

Conversation

@a-nogikh
Copy link
Collaborator

When determining whether a patch series is worth fuzzing, consider not only the hashes of .text symbols, but also the hashes of the global (static and non-static) variables.

As before, calculate the hashes during build and process them at the beginning of the fuzz step.

@a-nogikh a-nogikh requested a review from tarasmadan August 29, 2025 12:34
When determining whether a patch series is worth fuzzing, consider not
only the hashes of .text symbols, but also the hashes of the global
(static and non-static) variables.

As before, calculate the hashes during build and process them at the
beginning of the fuzz step.
@a-nogikh a-nogikh force-pushed the features/data-names branch from 596cded to 56b03ee Compare August 29, 2025 12:55
@a-nogikh a-nogikh added this pull request to the merge queue Aug 29, 2025
Merged via the queue into google:master with commit 807a3b6 Aug 29, 2025
18 checks passed
@dvyukov
Copy link
Collaborator

dvyukov commented Aug 29, 2025

How much is this different from the old existing hashes of all sections? .data was the main difference. There are things like relocations, but these either don't change if nothing in .text/.data has changed, or if changed can have the same effect as changes in .data.

@a-nogikh
Copy link
Collaborator Author

a-nogikh commented Sep 1, 2025

Yes, that needs to checked now.

We anyway need to determine the exact differing .text symbols because these are used to direct the fuzzer, but elfBinarySignature can now probably be reused instead of querying the individual changed symbols.

For .text it's also still important to calculate the hashes on vmlinux.o rather than vmlinux because, if even one symbol differs, there's a chance that, once the call sites are patched with the final PC values, many more symbols will differ as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants