-
Notifications
You must be signed in to change notification settings - Fork 1.4k
sys/linux: assorted socket_inet fixes #6357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/linux: assorted socket_inet fixes #6357
Conversation
6c77306 to
367f383
Compare
|
The tests are failing with: Looks like the syzkaller/tools/syz-trace2syz/proggen/proggen.go Lines 439 to 448 in e2beed9
We could adjust the tests and silence the error, but it means the tool becomes (even more) broken. Cc @dvyukov |
Adjust/disable tests. To the best of my knowledge nobody never used this tool. |
367f383 to
c2a6945
Compare
|
Dropped the tests, now all CI checks pass. The only concern is that |
|
|
You also had some seed that uses these calls. Do you want to add it? |
The syscall expects non-zero terminated strings.
This is the proper level for TLS_RX/TLS_TX opts.
c2a6945 to
4951e34
Compare
Not yet, still not sure if the seed brings any actual value (it doesn't help discover the crash during fuzzing, not sure about it giving extra coverage yet). |
|
@dvyukov PTAL |
See individual commits.