tools/create-image.sh: improve help message, add option to specify output prefix #6507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the help message: - sort options alphabetically - print default values - print first line to stdout like the rest of the message - fix typos, improve style Also sort the options parsing to be alphabetical (except --help), and use spaces consistently for indentation in this section. Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
Add an option, -o / --output, to specify a prefix used for the name of the directory where debootstrap generates the system, and the final disk image and SSH key filenames. The default remains using the distro release codename. For now, ban the use of slashes, spaces, . and .. as output names. Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
a-nogikh
approved these changes
Dec 15, 2025
Collaborator
a-nogikh
left a comment
a-nogikh
left a comment
There was a problem hiding this comment.
Thanks!
FWIW we now mostly use Buildroot images on syzbot that are created via https://github.com/google/syzkaller/blob/master/tools/create-buildroot-image.sh. If that also works for your use cases, it might be more straightforward to deal with.
Contributor
Author
|
Buildroot would be ideal for my use cases, but I have enough other problems to fix right now that switching to buildroot is a fair way down the list :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option,
-o/--output, to specify the name of the output directory/images/SSH keys generated bycreate-image.sh.While we're there, improve the help message to make it more useful and fix some typos, and fix up some code formatting in the options parser.