dashboard/app: add pprof handlers #6517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
reviewed
Dec 20, 2025
Collaborator
tarasmadan
left a comment
tarasmadan
left a comment
There was a problem hiding this comment.
- Do you know how expensive is it for the AppEngine application?
- In case of any Access Control issues, will this feature give potential attacker additional benefits?
These are useful for debugging of deadlocks, hangs (slowness), and memory consumption issues. Can be used on a local instance during development. On the production system pprof handlers are restricted to admins only.
dvyukov
force-pushed
the
dvyukov-dashboard-pprof
branch
from
cea2417 to
84f35ba
Compare
Collaborator
Author
There shouldn't be any cost, if the handlers are not called.
Can't think of any significant. I would be more concerned about our admin handlers, if the Access Control is somehow broken. |
tarasmadan
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are useful for debugging of deadlocks, hangs (slowness),
and memory consumption issues.
Can be used on a local instance during development.
On the production system pprof handlers are restricted to admins only.