all: run make generate #6642
Closed
all: run make generate #6642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like it hasn't been updated in a while. make generate also changes FLATBUFFERS_VERSION_* in pkg/flatrpc/flatrpc.h but they seem to break the presubmit CI so I settled for just format_cpp.
FlorentRevest
force-pushed
the
make-generate
branch
from
23dc35c to
5d9c0b5
Compare
Collaborator
|
For formatting of C/C++ files we rely on May be possible to fix some of these differences by adding more rules to |
dvyukov
added
the
AI patching
Collaborator
Author
|
Ah - that makes sense, I'll close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a couple of files haven't been updated in a while.