pkg/mgrconfig: change the snapshot attr semantics #6653
Closed
+9
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment of its introduction, the attribute was overridable by enable_syscalls. However, since some of the malicious calls are actually variants of generic syscalls (e.g. ioctl), it has de-facto made it very easy to enable them also on non-snapshot instances.
Do not let enable_syscalls override this. Instead, only activate snapshot calls on the snapshot instances.