all: enforce context.Context rules #6654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
force-pushed
the
context-is-ctx
branch
3 times, most recently
from
f31fd1c to
30982a5
Compare
tarasmadan
requested review from
dvyukov
and removed request for
eepeep,
glpesk and
mvanotti
tarasmadan
force-pushed
the
context-is-ctx
branch
2 times, most recently
from
a80c473 to
d051fa8
Compare
tarasmadan
commented
Jan 21, 2026
tarasmadan
force-pushed
the
context-is-ctx
branch
3 times, most recently
from
b68fa27 to
3521dcd
Compare
dvyukov
reviewed
Jan 21, 2026
Collaborator
|
Nice! |
tarasmadan
force-pushed
the
context-is-ctx
branch
from
3521dcd to
64c4c3d
Compare
1. It is the first parameter everywhere except tests. 2. It is the second param in the tests. 3. It is always named ctx. 4. For the cases with multiple contexts recommend to opt-out syz-linter.
tarasmadan
force-pushed
the
context-is-ctx
branch
from
64c4c3d to
6db82c5
Compare
dvyukov
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was vibe coded as an experiment.