Skip to content

pkg/report: don't print empty FRAME in failing tests #6435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarasmadan merged 1 commit into from
Oct 30, 2025
Merged

pkg/report: don't print empty FRAME in failing tests #6435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/report/report_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func (test *ParseTest) Equal(other *ParseTest) bool {
return test.Executor == other.Executor
}

func (test *ParseTest) Headers(includeFrame bool) []byte {
func (test *ParseTest) Headers() []byte {
buf := new(bytes.Buffer)
fmt.Fprintf(buf, "TITLE: %v\n", test.Title)
for _, t := range test.AltTitles {
Expand All @@ -76,7 +76,7 @@ func (test *ParseTest) Headers(includeFrame bool) []byte {
if test.Type != crash.UnknownType {
fmt.Fprintf(buf, "TYPE: %v\n", test.Type)
}
if includeFrame {
if test.Frame != "" {
fmt.Fprintf(buf, "FRAME: %v\n", test.Frame)
}
if test.Corrupted {
Expand Down Expand Up @@ -238,7 +238,7 @@ func testParseImpl(t *testing.T, reporter *Reporter, test *ParseTest) {
updateReportTest(t, test, parsed)
}
t.Fatalf("want:\n%s\ngot:\n%sCorrupted reason: %q",
test.Headers(true), parsed.Headers(true), parsed.corruptedReason)
test.Headers(), parsed.Headers(), parsed.corruptedReason)
}
if parsed.Title != "" && len(rep.Report) == 0 {
t.Fatalf("found crash message but report is empty")
Expand Down Expand Up @@ -293,7 +293,7 @@ func checkReport(t *testing.T, reporter *Reporter, rep *Report, test *ParseTest)

func updateReportTest(t *testing.T, test, parsed *ParseTest) {
buf := new(bytes.Buffer)
buf.Write(parsed.Headers(test.Frame != ""))
buf.Write(parsed.Headers())
fmt.Fprintf(buf, "\n%s", test.Log)
if test.HasReport {
fmt.Fprintf(buf, "REPORT:\n%s", parsed.Report)
Expand Down Expand Up @@ -396,7 +396,7 @@ func testSymbolizeFile(t *testing.T, reporter *Reporter, fn string) {
}
assert.Equal(t, string(test.Report), string(rep.Report), "extracted wrong report")
t.Fatalf("want:\n%s\ngot:\n%sCorrupted reason: %q",
test.Headers(true), parsed.Headers(true), parsed.corruptedReason)
test.Headers(), parsed.Headers(), parsed.corruptedReason)
}
}

Expand Down