Skip to content

two minor fixes in preparation for AI patch generation #6514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvyukov merged 2 commits into from
Dec 18, 2025
Merged

two minor fixes in preparation for AI patch generation #6514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
580a33e
pkg/instance: improve comment about returned errors
dvyukov Dec 18, 2025
c38dce0
pkg/mgrconfig: export defaultValues function
dvyukov Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/instance/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,8 @@ func (err *CrashError) Error() string {
}

// Test boots numVMs VMs, tests basic kernel operation, and optionally tests the provided reproducer.
// TestError is returned if there is a problem with kernel/image (crash, reboot loop, etc).
// CrashError is returned if the reproducer crashes kernel.
// *TestError is returned if there is a problem with kernel/image (crash, reboot loop, etc).
// *CrashError is returned if the reproducer crashes kernel.
func (env *env) Test(numVMs int, reproSyz, reproOpts, reproC []byte) ([]EnvTestResult, error) {
if env.testSem != nil {
env.testSem.Wait()
Expand Down
6 changes: 3 additions & 3 deletions pkg/mgrconfig/load.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func LoadFile(filename string) (*Config, error) {
}

func LoadPartialData(data []byte) (*Config, error) {
cfg := defaultValues()
cfg := DefaultValues()
if err := config.LoadData(data, cfg); err != nil {
return nil, err
}
Expand All @@ -80,7 +80,7 @@ func LoadPartialData(data []byte) (*Config, error) {
}

func LoadPartialFile(filename string) (*Config, error) {
cfg := defaultValues()
cfg := DefaultValues()
if err := config.LoadFile(filename, cfg); err != nil {
return nil, err
}
Expand All @@ -90,7 +90,7 @@ func LoadPartialFile(filename string) (*Config, error) {
return cfg, nil
}

func defaultValues() *Config {
func DefaultValues() *Config {
return &Config{
SSHUser: "root",
Cover: true,
Expand Down
Loading