Skip to content

tools/clang/codesearch: migrate dyn_cast to dyn_cast_if_present #6700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvyukov merged 1 commit into from
Jan 27, 2026
+5 −5
Merged

tools/clang/codesearch: migrate dyn_cast to dyn_cast_if_present #6700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tools/clang/codesearch/codesearch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ bool Indexer::TraverseCallExpr(CallExpr* CE) {
}

bool Indexer::VisitDeclRefExpr(const DeclRefExpr* DeclRef) {
if (const auto* Func = dyn_cast<FunctionDecl>(DeclRef->getDecl()))
if (const auto* Func = dyn_cast_if_present<FunctionDecl>(DeclRef->getDecl()))
EmitReference(DeclRef->getBeginLoc(), DeclRef->getDecl(), EntityKindFunction,
InCallee ? RefKindCall : RefKindTakesAddr);
return true;
Expand Down Expand Up @@ -246,25 +246,25 @@ bool Indexer::VisitTypedefType(const TypedefType* T) {
return true;
EmitReference(TypeRefingLocation, T->getDecl(), EntityKindTypedef, RefKindUses);
// If it's a struct typedef, also note the struct use.
if (const auto* Tag = dyn_cast<TagType>(T->getCanonicalTypeInternal().getTypePtr()))
if (const auto* Tag = dyn_cast_if_present<TagType>(T->getCanonicalTypeInternal().getTypePtr()))
VisitTagType(Tag);
return true;
}

bool Indexer::VisitMemberExpr(const MemberExpr* E) {
auto* Record = E->getBase()->getType()->getAsRecordDecl();
if (auto* Ptr = dyn_cast<PointerType>(E->getBase()->getType()))
if (auto* Ptr = dyn_cast_if_present<PointerType>(E->getBase()->getType()))
Record = Ptr->getPointeeType()->getAsRecordDecl();
if (!Record)
return true;
const std::string Field = Record->getNameAsString() + "::" + E->getMemberDecl()->getNameAsString();
const char* RefKind = RefKindRead;
const Stmt* P = GetParent(E);
if (auto* BO = dyn_cast<BinaryOperator>(P)) {
if (auto* BO = dyn_cast_if_present<BinaryOperator>(P)) {
if (E == BO->getLHS() && (BO->isAssignmentOp() || BO->isCompoundAssignmentOp() || BO->isShiftAssignOp()))
RefKind = RefKindWrite;
}
if (auto* UO = dyn_cast<UnaryOperator>(P))
if (auto* UO = dyn_cast_if_present<UnaryOperator>(P))
RefKind = RefKindTakesAddr;
EmitReference(E->getMemberLoc(), Field, EntityKindField, RefKind);
return true;
Expand Down
Loading