Skip to content

Commit 3b487e0

Browse files
committed
Temp debugging
1 parent 2bd5b21 commit 3b487e0

File tree

2 files changed

+48
-41
lines changed

2 files changed

+48
-41
lines changed

.github/workflows/tests.yml

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,22 @@ jobs:
1717
# Maintenance
1818
- node: 18
1919
os: ubuntu-22.04
20-
- node: 18
21-
os: macos-13
22-
- node: 18
23-
os: windows-2022
20+
# - node: 18
21+
# os: macos-13
22+
# - node: 18
23+
# os: windows-2022
2424

25-
# LTS
26-
- node: 20
27-
os: ubuntu-22.04
25+
# # LTS
26+
# - node: 20
27+
# os: ubuntu-22.04
2828

29-
# Current
30-
- node: 22
31-
os: ubuntu-22.04
32-
- node: 22
33-
os: macos-13
34-
- node: 22
35-
os: windows-2022
29+
# # Current
30+
# - node: 22
31+
# os: ubuntu-22.04
32+
# - node: 22
33+
# os: macos-13
34+
# - node: 22
35+
# os: windows-2022
3636

3737
# Allow all matrix configurations to complete, instead of cancelling as
3838
# soon as one fails. Useful because we often have different kinds of
@@ -61,28 +61,28 @@ jobs:
6161

6262
- run: npm ci
6363

64-
# See https://code.visualstudio.com/api/working-with-extensions/continuous-integration#github-actions for why we need xvfb-run
65-
- run: npm test
66-
if: runner.os != 'Linux'
67-
# We run tests in parallel on Linux, but not on other OSs. This is
68-
# because the Mac and Windows runners are very flaky, and parallelism
69-
# makes them worse.
70-
env:
71-
WIREIT_PARALLEL: 1
72-
- run: xvfb-run -a npm test
73-
if: runner.os == 'Linux'
64+
# # See https://code.visualstudio.com/api/working-with-extensions/continuous-integration#github-actions for why we need xvfb-run
65+
# - run: npm test
66+
# if: runner.os != 'Linux'
67+
# # We run tests in parallel on Linux, but not on other OSs. This is
68+
# # because the Mac and Windows runners are very flaky, and parallelism
69+
# # makes them worse.
70+
# env:
71+
# WIREIT_PARALLEL: 1
72+
# - run: xvfb-run -a npm test
73+
# if: runner.os == 'Linux'
7474
- run: npm run test:cache-github-real
7575

76-
lint-and-format:
77-
timeout-minutes: 5
78-
runs-on: ubuntu-22.04
79-
steps:
80-
- uses: actions/checkout@v4
81-
- uses: actions/setup-node@v4
82-
with:
83-
node-version: 20
84-
cache: npm
76+
# lint-and-format:
77+
# timeout-minutes: 5
78+
# runs-on: ubuntu-22.04
79+
# steps:
80+
# - uses: actions/checkout@v4
81+
# - uses: actions/setup-node@v4
82+
# with:
83+
# node-version: 20
84+
# cache: npm
8585

86-
- run: npm ci
87-
- run: npm run lint
88-
- run: npm run format:check
86+
# - run: npm ci
87+
# - run: npm run lint
88+
# - run: npm run format:check

src/caching/github-actions-cache.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -206,11 +206,18 @@ export class GitHubActionsCache implements Cache {
206206

207207
const version = this.#computeVersion(fingerprint);
208208
const key = this.#computeCacheKey(script);
209-
const url = new URL(
210-
// See https://github.com/actions/toolkit/blob/930c89072712a3aac52d74b23338f00bb0cfcb24/packages/cache/src/generated/results/api/v1/cache.twirp-client.ts#L91
211-
'twirp/github.actions.results.api.v1.CacheService/GetCacheEntryDownloadURL',
212-
this.#baseUrl,
213-
);
209+
console.log('BASEURL', this.#baseUrl);
210+
let url;
211+
try {
212+
url = new URL(
213+
// See https://github.com/actions/toolkit/blob/930c89072712a3aac52d74b23338f00bb0cfcb24/packages/cache/src/generated/results/api/v1/cache.twirp-client.ts#L91
214+
'twirp/github.actions.results.api.v1.CacheService/GetCacheEntryDownloadURL',
215+
this.#baseUrl,
216+
);
217+
} catch (e) {
218+
console.error(e);
219+
throw e;
220+
}
214221
// See https://github.com/actions/toolkit/blob/930c89072712a3aac52d74b23338f00bb0cfcb24/packages/cache/src/cache.ts#L246
215222
// and https://github.com/actions/toolkit/blob/930c89072712a3aac52d74b23338f00bb0cfcb24/packages/cache/src/generated/results/api/v1/cache.ts#L101C1-L126C2
216223
const requestBody = {key, version};

0 commit comments

Comments
 (0)