Include the span of the argument when InferImplicitParametrics fails on a function argument.

See #3979

The mistake in that example is the wrong order of the intended names in the `let (data, tok) = recv(...)`, which actually leads to the first arg to send being the wrong type. This change adds the span for the `tok` argument of the actual `send` call to the error (that is the point where type inference actually fails).

PiperOrigin-RevId: 886977632

Author: richmckeever

xls/dslx/type_system_v2/BUILD

@@ -228,6 +228,7 @@ cc_library(
         "//xls/dslx:errors",
         "//xls/dslx:import_data",
         "//xls/dslx:interp_value",
+        "//xls/dslx:status_payload_utils",
         "//xls/dslx:warning_collector",
         "//xls/dslx/frontend:ast",
         "//xls/dslx/frontend:ast_cloner",

xls/dslx/type_system_v2/inference_table_converter_impl.cc

@@ -55,6 +55,7 @@
 #include "xls/dslx/frontend/semantics_analysis.h"
 #include "xls/dslx/import_data.h"
 #include "xls/dslx/interp_value.h"
+#include "xls/dslx/status_payload_utils.h"
 #include "xls/dslx/type_system/parametric_env.h"
 #include "xls/dslx/type_system/type.h"
 #include "xls/dslx/type_system/type_info.h"
@@ -2089,8 +2090,11 @@ class InferenceTableConverterImpl : public InferenceTableConverter,
             resolver_->ResolveIndirectTypeAnnotations(
                 target_context, actual_args[i], formal_types[i],
                 TypeAnnotationFilter::None()));
-        return TypeMismatchError(actual_arg_context, direct_actual_arg_type,
-                                 direct_formal_arg_type);
+        absl::Status error = TypeMismatchError(
+            actual_arg_context, direct_actual_arg_type, direct_formal_arg_type);
+        AddSpanToStatusPayload(error, actual_args[i]->span(),
+                               const_cast<FileTable&>(file_table_));
+        return error;
       }
       for (auto& [binding, value_or_type] : *resolved) {
         VLOG(5) << "Inferred implicit parametric value: "

xls/dslx/type_system_v2/typecheck_module_v2_builtin_test.cc

@@ -1621,6 +1621,36 @@ proc P {
       TypecheckFails(HasTypeMismatch("bool", "u32")));
 }
 
+TEST(TypecheckV2Test, SendWithWrongArgumentOrder) {
+  EXPECT_THAT(R"(
+struct S {
+  x: u32
+}
+
+type Foo = S;
+
+proc Rep {
+  input: chan<Foo> in;
+  output: chan<Foo> out;
+
+  init { () }
+
+  config(input: chan<Foo> in, output: chan<Foo> out) {
+    (input, output)
+  }
+
+  next(a: ()) {
+    let (data, tok) = recv(join(), input);
+    let tok = send(tok, output, data);
+  }
+}
+)",
+              TypecheckFailsWithPayload(HasTypeMismatch("S", "token"),
+                                        // The span of the `tok` argument in the
+                                        // `send` call should be one of them.
+                                        HasSpan(21, 19, 21, 22)));
+}
+
 TEST(TypecheckV2BuiltinTest, Recv) {
   EXPECT_THAT(
       R"(