[ci] Roll pinned nightly toolchain (#2753)

joshlf · jswrenn · web-flow · commit 6b8a748759a5 · 2025-11-13T16:33:31.000Z
Co-authored-by: Jack Wrenn &lt;jswrenn@amazon.com&gt;
diff --git a/Cargo.toml b/Cargo.toml
@@ -60,7 +60,7 @@ zerocopy-panic-in-const-and-vec-try-reserve-1-57-0 = "1.57.0"
 [package.metadata.ci]
 # The versions of the stable and nightly compiler toolchains to use in CI.
 pinned-stable = "1.90.0"
-pinned-nightly = "nightly-2025-10-17"
+pinned-nightly = "nightly-2025-11-04"
 
 [package.metadata.docs.rs]
 all-features = true
diff --git a/src/util/mod.rs b/src/util/mod.rs
@@ -362,6 +362,7 @@ where
         }
     } else {
         let align = T::LAYOUT.align.get();
+
         // We use `transmute` instead of an `as` cast since Miri (with strict
         // provenance enabled) notices and complains that an `as` cast creates a
         // pointer with no provenance. Miri isn't smart enough to realize that
@@ -370,7 +371,9 @@ where
         //
         // SAFETY: any initialized bit sequence is a bit-valid `*mut u8`. All
         // bits of a `usize` are initialized.
-        #[allow(unknown_lints)] // For `integer_to_ptr_transmutes`
+        //
+        // `#[allow(unknown_lints)]` is for `integer_to_ptr_transmutes`
+        #[allow(unknown_lints)]
         #[allow(clippy::useless_transmute, integer_to_ptr_transmutes)]
         let dangling = unsafe { mem::transmute::<usize, *mut u8>(align) };
         // SAFETY: `dangling` is constructed from `T::LAYOUT.align`, which is a
diff --git a/src/wrappers.rs b/src/wrappers.rs
@@ -119,6 +119,19 @@ pub struct Unalign<T>(T);
 // `KnownLayout` impl bounded on `T: KnownLayout.` This is overly restrictive.
 impl_known_layout!(T => Unalign<T>);
 
+// FIXME(https://github.com/rust-lang/rust-clippy/issues/16087): Move these
+// attributes below the comment once this Clippy bug is fixed.
+#[cfg_attr(
+    all(__ZEROCOPY_INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTS, any(feature = "derive", test)),
+    expect(unused_unsafe)
+)]
+#[cfg_attr(
+    all(
+        not(__ZEROCOPY_INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTS),
+        any(feature = "derive", test)
+    ),
+    allow(unused_unsafe)
+)]
 // SAFETY:
 // - `Unalign<T>` promises to have alignment 1, and so we don't require that `T:
 //   Unaligned`.
@@ -128,7 +141,7 @@ impl_known_layout!(T => Unalign<T>);
 //   `UnsafeCell`s exactly when `T` does.
 // - `TryFromBytes`: `Unalign<T>` has the same the same bit validity as `T`, so
 //   `T::is_bit_valid` is a sound implementation of `is_bit_valid`.
-#[allow(unused_unsafe)] // Unused when `feature = "derive"`.
+//
 const _: () = unsafe {
     impl_or_verify!(T => Unaligned for Unalign<T>);
     impl_or_verify!(T: Immutable => Immutable for Unalign<T>);
diff --git a/tests/ui-nightly/transmute-ptr-to-usize.stderr b/tests/ui-nightly/transmute-ptr-to-usize.stderr
@@ -8,7 +8,11 @@ error[E0277]: the trait bound `*const usize: IntoBytes` is not satisfied
    |                              required by a bound introduced by this call
    |
    = note: Consider adding `#[derive(IntoBytes)]` to `*const usize`
-   = help: the trait `IntoBytes` is implemented for `usize`
+help: the trait `IntoBytes` is implemented for `usize`
+  --> src/impls.rs
+   |
+   |     unsafe_impl!(usize: Immutable, TryFromBytes, FromZeros, FromBytes, IntoBytes);
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 note: required by a bound in `POINTER_VALUE::transmute`
   --> tests/ui-nightly/transmute-ptr-to-usize.rs:20:30
    |
diff --git a/zerocopy-derive/Cargo.toml b/zerocopy-derive/Cargo.toml
@@ -45,6 +45,7 @@ libc = "=0.2.163"
 # This is the latest version which is compatible with `syn` 2.0.46, which we pin
 # to in CI for MSRV compatibility reasons.
 prettyplease = "=0.2.17"
+proc-macro2 = "=1.0.80"
 quote = "=1.0.40"
 rustversion = "1.0"
 static_assertions = "1.1"
diff --git a/zerocopy-derive/tests/struct_to_bytes.rs b/zerocopy-derive/tests/struct_to_bytes.rs
@@ -48,15 +48,15 @@ util_assert_impl_all!(C: imp::IntoBytes);
 #[repr(transparent)]
 struct Transparent {
     a: u8,
-    b: CZst,
+    b: (),
 }
 
 util_assert_impl_all!(Transparent: imp::IntoBytes);
 
 #[derive(imp::IntoBytes)]
 #[repr(transparent)]
 struct TransparentGeneric<T: ?imp::Sized> {
-    a: CZst,
+    a: (),
     b: T,
 }
 
diff --git a/zerocopy-derive/tests/ui-nightly/enum.stderr b/zerocopy-derive/tests/ui-nightly/enum.stderr
@@ -467,8 +467,12 @@ error[E0277]: `IntoBytes1` has 1 total byte(s) of padding
     = note: consider using `zerocopy::Unalign` to lower the alignment of individual fields
     = note: consider adding explicit fields where padding would be
     = note: consider using `#[repr(packed)]` to remove padding
-    = help: the trait `PaddingFree<IntoBytes1, 1>` is not implemented for `()`
-            but trait `PaddingFree<IntoBytes1, 0>` is implemented for it
+help: the trait `PaddingFree<IntoBytes1, 1>` is not implemented for `()`
+      but trait `PaddingFree<IntoBytes1, 0>` is implemented for it
+   --> $WORKSPACE/src/util/macro_util.rs
+    |
+ 63 | impl<T: ?Sized> PaddingFree<T, 0> for () {}
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: see issue #48214
     = note: this error originates in the derive macro `IntoBytes` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: add `#![feature(trivial_bounds)]` to the crate attributes to enable
@@ -485,8 +489,12 @@ error[E0277]: `IntoBytes2` has 3 total byte(s) of padding
     = note: consider using `zerocopy::Unalign` to lower the alignment of individual fields
     = note: consider adding explicit fields where padding would be
     = note: consider using `#[repr(packed)]` to remove padding
-    = help: the trait `PaddingFree<IntoBytes2, 3>` is not implemented for `()`
-            but trait `PaddingFree<IntoBytes2, 0>` is implemented for it
+help: the trait `PaddingFree<IntoBytes2, 3>` is not implemented for `()`
+      but trait `PaddingFree<IntoBytes2, 0>` is implemented for it
+   --> $WORKSPACE/src/util/macro_util.rs
+    |
+ 63 | impl<T: ?Sized> PaddingFree<T, 0> for () {}
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: see issue #48214
     = note: this error originates in the derive macro `IntoBytes` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: add `#![feature(trivial_bounds)]` to the crate attributes to enable
@@ -503,8 +511,12 @@ error[E0277]: `IntoBytes3` has 2 total byte(s) of padding
     = note: consider using `zerocopy::Unalign` to lower the alignment of individual fields
     = note: consider adding explicit fields where padding would be
     = note: consider using `#[repr(packed)]` to remove padding
-    = help: the trait `PaddingFree<IntoBytes3, 2>` is not implemented for `()`
-            but trait `PaddingFree<IntoBytes3, 0>` is implemented for it
+help: the trait `PaddingFree<IntoBytes3, 2>` is not implemented for `()`
+      but trait `PaddingFree<IntoBytes3, 0>` is implemented for it
+   --> $WORKSPACE/src/util/macro_util.rs
+    |
+ 63 | impl<T: ?Sized> PaddingFree<T, 0> for () {}
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: see issue #48214
     = note: this error originates in the derive macro `IntoBytes` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: add `#![feature(trivial_bounds)]` to the crate attributes to enable
diff --git a/zerocopy-derive/tests/ui-nightly/struct.stderr b/zerocopy-derive/tests/ui-nightly/struct.stderr
@@ -320,8 +320,12 @@ error[E0277]: `IntoBytes2` has 1 total byte(s) of padding
     = note: consider using `zerocopy::Unalign` to lower the alignment of individual fields
     = note: consider adding explicit fields where padding would be
     = note: consider using `#[repr(packed)]` to remove padding
-    = help: the trait `PaddingFree<IntoBytes2, 1>` is not implemented for `()`
-            but trait `PaddingFree<IntoBytes2, 0>` is implemented for it
+help: the trait `PaddingFree<IntoBytes2, 1>` is not implemented for `()`
+      but trait `PaddingFree<IntoBytes2, 0>` is implemented for it
+   --> $WORKSPACE/src/util/macro_util.rs
+    |
+ 63 | impl<T: ?Sized> PaddingFree<T, 0> for () {}
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: see issue #48214
     = note: this error originates in the derive macro `IntoBytes` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: add `#![feature(trivial_bounds)]` to the crate attributes to enable
@@ -338,8 +342,12 @@ error[E0277]: `IntoBytes3` has 1 total byte(s) of padding
     = note: consider using `zerocopy::Unalign` to lower the alignment of individual fields
     = note: consider adding explicit fields where padding would be
     = note: consider using `#[repr(packed)]` to remove padding
-    = help: the trait `PaddingFree<IntoBytes3, 1>` is not implemented for `()`
-            but trait `PaddingFree<IntoBytes3, 0>` is implemented for it
+help: the trait `PaddingFree<IntoBytes3, 1>` is not implemented for `()`
+      but trait `PaddingFree<IntoBytes3, 0>` is implemented for it
+   --> $WORKSPACE/src/util/macro_util.rs
+    |
+ 63 | impl<T: ?Sized> PaddingFree<T, 0> for () {}
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: see issue #48214
     = note: this error originates in the derive macro `IntoBytes` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: add `#![feature(trivial_bounds)]` to the crate attributes to enable
@@ -392,8 +400,12 @@ error[E0277]: `IntoBytes5` has one or more padding bytes
     = note: consider using `zerocopy::Unalign` to lower the alignment of individual fields
     = note: consider adding explicit fields where padding would be
     = note: consider using `#[repr(packed)]` to remove padding
-    = help: the trait `DynamicPaddingFree<IntoBytes5, true>` is not implemented for `()`
-            but trait `DynamicPaddingFree<IntoBytes5, false>` is implemented for it
+help: the trait `DynamicPaddingFree<IntoBytes5, true>` is not implemented for `()`
+      but trait `DynamicPaddingFree<IntoBytes5, false>` is implemented for it
+   --> $WORKSPACE/src/util/macro_util.rs
+    |
+ 81 | impl<T: ?Sized> DynamicPaddingFree<T, false> for () {}
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: see issue #48214
     = note: this error originates in the derive macro `IntoBytes` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: add `#![feature(trivial_bounds)]` to the crate attributes to enable
@@ -410,8 +422,12 @@ error[E0277]: `IntoBytes6` has one or more padding bytes
     = note: consider using `zerocopy::Unalign` to lower the alignment of individual fields
     = note: consider adding explicit fields where padding would be
     = note: consider using `#[repr(packed)]` to remove padding
-    = help: the trait `DynamicPaddingFree<IntoBytes6, true>` is not implemented for `()`
-            but trait `DynamicPaddingFree<IntoBytes6, false>` is implemented for it
+help: the trait `DynamicPaddingFree<IntoBytes6, true>` is not implemented for `()`
+      but trait `DynamicPaddingFree<IntoBytes6, false>` is implemented for it
+   --> $WORKSPACE/src/util/macro_util.rs
+    |
+ 81 | impl<T: ?Sized> DynamicPaddingFree<T, false> for () {}
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: see issue #48214
     = note: this error originates in the derive macro `IntoBytes` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: add `#![feature(trivial_bounds)]` to the crate attributes to enable
@@ -428,8 +444,12 @@ error[E0277]: `IntoBytes7` has one or more padding bytes
     = note: consider using `zerocopy::Unalign` to lower the alignment of individual fields
     = note: consider adding explicit fields where padding would be
     = note: consider using `#[repr(packed)]` to remove padding
-    = help: the trait `DynamicPaddingFree<IntoBytes7, true>` is not implemented for `()`
-            but trait `DynamicPaddingFree<IntoBytes7, false>` is implemented for it
+help: the trait `DynamicPaddingFree<IntoBytes7, true>` is not implemented for `()`
+      but trait `DynamicPaddingFree<IntoBytes7, false>` is implemented for it
+   --> $WORKSPACE/src/util/macro_util.rs
+    |
+ 81 | impl<T: ?Sized> DynamicPaddingFree<T, false> for () {}
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: see issue #48214
     = note: this error originates in the derive macro `IntoBytes` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: add `#![feature(trivial_bounds)]` to the crate attributes to enable
@@ -479,10 +499,19 @@ error[E0277]: the trait bound `u8: SplitAt` is not satisfied
     |          ^^^^^^^ the trait `SplitAt` is not implemented for `u8`
     |
     = note: Consider adding `#[derive(SplitAt)]` to `u8`
-    = help: the following other types implement trait `SplitAt`:
-              SplitAtNotKnownLayout
-              SplitAtSized
-              [T]
+help: the following other types implement trait `SplitAt`
+   --> tests/ui-nightly/struct.rs:248:10
+    |
+248 | #[derive(SplitAt)]
+    |          ^^^^^^^ `SplitAtNotKnownLayout`
+...
+252 | #[derive(SplitAt, KnownLayout)]
+    |          ^^^^^^^ `SplitAtSized`
+    |
+   ::: $WORKSPACE/src/split_at.rs
+    |
+    | unsafe impl<T> SplitAt for [T] {
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `[T]`
     = help: see issue #48214
     = note: this error originates in the derive macro `SplitAt` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: add `#![feature(trivial_bounds)]` to the crate attributes to enable
diff --git a/zerocopy-derive/tests/ui-nightly/union.stderr b/zerocopy-derive/tests/ui-nightly/union.stderr
@@ -110,8 +110,12 @@ error[E0277]: `IntoBytes2` has 1 total byte(s) of padding
    = note: consider using `zerocopy::Unalign` to lower the alignment of individual fields
    = note: consider adding explicit fields where padding would be
    = note: consider using `#[repr(packed)]` to remove padding
-   = help: the trait `PaddingFree<IntoBytes2, 1>` is not implemented for `()`
-           but trait `PaddingFree<IntoBytes2, 0>` is implemented for it
+help: the trait `PaddingFree<IntoBytes2, 1>` is not implemented for `()`
+      but trait `PaddingFree<IntoBytes2, 0>` is implemented for it
+  --> $WORKSPACE/src/util/macro_util.rs
+   |
+   | impl<T: ?Sized> PaddingFree<T, 0> for () {}
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: see issue #48214
    = note: this error originates in the derive macro `IntoBytes` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: add `#![feature(trivial_bounds)]` to the crate attributes to enable

Original file line number	Diff line number	Diff line change
@@ -8,7 +8,11 @@ error[E0277]: the trait bound `*const usize: IntoBytes` is not satisfied
`8`	`8`	`\| required by a bound introduced by this call`
`9`	`9`	`\|`
`10`	`10`	= note: Consider adding `#[derive(IntoBytes)]` to `*const usize`
`11`		- = help: the trait `IntoBytes` is implemented for `usize`
	`11`	+help: the trait `IntoBytes` is implemented for `usize`
	`12`	`+ --> src/impls.rs`
	`13`	`+ \|`
	`14`	`+ \| unsafe_impl!(usize: Immutable, TryFromBytes, FromZeros, FromBytes, IntoBytes);`
	`15`	`+ \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^`
`12`	`16`	note: required by a bound in `POINTER_VALUE::transmute`
`13`	`17`	`--> tests/ui-nightly/transmute-ptr-to-usize.rs:20:30`
`14`	`18`	`\|`