Skip to content

Commit 02ca0da

Browse files
Nicholas Ventimigliacopybara-github
authored andcommitted
Replace View.GONE with View.INVISIBLE for banner ads.
PiperOrigin-RevId: 940695795
1 parent cee8b0e commit 02ca0da

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/Banner.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ protected void createAdView(final String publisherId, final AdSize adSize) {
151151
adView.setBackgroundColor(Color.TRANSPARENT);
152152
adView.setAdUnitId(publisherId);
153153
adView.setAdSize(adSize);
154-
adView.setVisibility(View.GONE);
154+
adView.setVisibility(View.INVISIBLE);
155155
adView.setDescendantFocusability(ViewGroup.FOCUS_BLOCK_DESCENDANTS);
156156
unityPlayerActivity.addContentView(adView, getLayoutParams());
157157
adView.setAdListener(
@@ -346,15 +346,15 @@ public void run() {
346346
});
347347
}
348348

349-
/** Sets the {@link AdView} to be gone. */
349+
/** Sets the {@link AdView} to be invisible. */
350350
public void hide() {
351351
unityPlayerActivity.runOnUiThread(
352352
new Runnable() {
353353
@Override
354354
public void run() {
355355
Log.d(PluginUtils.LOGTAG, "Calling hide() on Android");
356356
hidden = true;
357-
adView.setVisibility(View.GONE);
357+
adView.setVisibility(View.INVISIBLE);
358358
adView.pause();
359359
}
360360
});

source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/admanager/UnityAdManagerBannerView.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ protected void createAdView(final String publisherId, final AdSize adSize) {
6868
adView.setBackgroundColor(Color.TRANSPARENT);
6969
adView.setAdUnitId(publisherId);
7070
adView.setAdSize(adSize);
71-
adView.setVisibility(View.GONE);
71+
adView.setVisibility(View.INVISIBLE);
7272
adView.setDescendantFocusability(ViewGroup.FOCUS_BLOCK_DESCENDANTS);
7373
unityPlayerActivity.addContentView(adView, getLayoutParams());
7474
adView.setAdListener(

source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/test/java/com/google/unity/ads/BannerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,9 @@ public void show_setsAdViewVisibilityToVisible() {
139139
}
140140

141141
@Test
142-
public void hide_setsAdViewVisibilityToGone() {
142+
public void hide_setsAdViewVisibilityToInvisible() {
143143
banner.hide();
144-
assertThat(banner.adView.getVisibility()).isEqualTo(View.GONE);
144+
assertThat(banner.adView.getVisibility()).isEqualTo(View.INVISIBLE);
145145
}
146146

147147
@Test

0 commit comments

Comments
 (0)