From 4e8410bafc06da23f5293381b1b78a64a30cf6f9 Mon Sep 17 00:00:00 2001 From: Nicholas Ventimiglia Date: Mon, 10 Aug 2026 09:39:39 -0700 Subject: [PATCH] Replace View.GONE with View.INVISIBLE for banner ads. PiperOrigin-RevId: 962203814 --- .../src/main/java/com/google/unity/ads/Banner.java | 6 +++--- .../unity/ads/admanager/UnityAdManagerBannerView.java | 2 +- .../src/test/java/com/google/unity/ads/BannerTest.java | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/Banner.java b/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/Banner.java index 8cae7d71f..df452d34b 100644 --- a/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/Banner.java +++ b/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/Banner.java @@ -151,7 +151,7 @@ protected void createAdView(final String publisherId, final AdSize adSize) { adView.setBackgroundColor(Color.TRANSPARENT); adView.setAdUnitId(publisherId); adView.setAdSize(adSize); - adView.setVisibility(View.GONE); + adView.setVisibility(View.INVISIBLE); adView.setDescendantFocusability(ViewGroup.FOCUS_BLOCK_DESCENDANTS); unityPlayerActivity.addContentView(adView, getLayoutParams()); adView.setAdListener( @@ -346,7 +346,7 @@ public void run() { }); } - /** Sets the {@link AdView} to be gone. */ + /** Sets the {@link AdView} to be invisible. */ public void hide() { unityPlayerActivity.runOnUiThread( new Runnable() { @@ -354,7 +354,7 @@ public void hide() { public void run() { Log.d(PluginUtils.LOGTAG, "Calling hide() on Android"); hidden = true; - adView.setVisibility(View.GONE); + adView.setVisibility(View.INVISIBLE); adView.pause(); } }); diff --git a/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/admanager/UnityAdManagerBannerView.java b/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/admanager/UnityAdManagerBannerView.java index 7499bed30..f222c12df 100644 --- a/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/admanager/UnityAdManagerBannerView.java +++ b/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/admanager/UnityAdManagerBannerView.java @@ -68,7 +68,7 @@ protected void createAdView(final String publisherId, final AdSize adSize) { adView.setBackgroundColor(Color.TRANSPARENT); adView.setAdUnitId(publisherId); adView.setAdSize(adSize); - adView.setVisibility(View.GONE); + adView.setVisibility(View.INVISIBLE); adView.setDescendantFocusability(ViewGroup.FOCUS_BLOCK_DESCENDANTS); unityPlayerActivity.addContentView(adView, getLayoutParams()); adView.setAdListener( diff --git a/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/test/java/com/google/unity/ads/BannerTest.java b/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/test/java/com/google/unity/ads/BannerTest.java index 4d76751a3..d81158615 100644 --- a/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/test/java/com/google/unity/ads/BannerTest.java +++ b/source/plugin/Assets/Plugins/Android/GoogleMobileAdsPlugin.androidlib/src/test/java/com/google/unity/ads/BannerTest.java @@ -139,9 +139,9 @@ public void show_setsAdViewVisibilityToVisible() { } @Test - public void hide_setsAdViewVisibilityToGone() { + public void hide_setsAdViewVisibilityToInvisible() { banner.hide(); - assertThat(banner.adView.getVisibility()).isEqualTo(View.GONE); + assertThat(banner.adView.getVisibility()).isEqualTo(View.INVISIBLE); } @Test