Skip to content

Commit df9f02b

Browse files
committed
Added Ad Customieout.
1 parent 2c6d43b commit df9f02b

File tree

8 files changed

+16
-10
lines changed

8 files changed

+16
-10
lines changed

ChangeLog

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
2.0.2 - 09/03/2014
2+
=================
3+
* Added Ad Customizer example for AdWords.
4+
* Extend timeout on SUDs to correspond to access token expiry.
5+
16
2.0.1 - 08/20/2014
27
=================
38
* Added support for v201408 for DFP client library.

googleads/adwords.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def GetService(self, service_name, version=sorted(_SERVICE_MAP.keys())[-1],
248248
client = suds.client.Client(
249249
self._SOAP_SERVICE_FORMAT %
250250
(server, _SERVICE_MAP[version][service_name], version, service_name),
251-
proxy=proxy_option, cache=self.cache, timeout=600)
251+
proxy=proxy_option, cache=self.cache, timeout=3600)
252252
except KeyError:
253253
if version in _SERVICE_MAP:
254254
raise googleads.errors.GoogleAdsValueError(

googleads/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import googleads.errors
2727
import googleads.oauth2
2828

29-
VERSION = '2.0.1'
29+
VERSION = '2.0.2'
3030
_COMMON_LIB_SIG = 'googleads/%s' % VERSION
3131
_PYTHON_VERSION = 'Python/%d.%d' % (sys.version_info[0], sys.version_info[1])
3232

googleads/dfa.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def GetService(self, service_name, version=sorted(_SERVICE_MAP.keys())[-1],
142142

143143
client = suds.client.Client(
144144
self._SOAP_SERVICE_FORMAT % (server, version, service_name),
145-
proxy=proxy_option, cache=self.cache)
145+
proxy=proxy_option, cache=self.cache, timeout=3600)
146146
except suds.transport.TransportError:
147147
if version in self._SERVICE_MAP:
148148
if service_name in self._SERVICE_MAP[version]:

googleads/dfp.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ def GetService(self, service_name, version=sorted(_SERVICE_MAP.keys())[-1],
206206

207207
client = suds.client.Client(
208208
self._SOAP_SERVICE_FORMAT % (server, version, service_name),
209-
proxy=proxy_option, cache=self.cache, timeout=600)
209+
proxy=proxy_option, cache=self.cache, timeout=3600)
210210
except suds.transport.TransportError:
211211
if version in _SERVICE_MAP:
212212
if service_name in _SERVICE_MAP[version]:

tests/adwords_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ def testGetService_success(self):
197197
mock_client.assert_called_once_with(
198198
'https://testing.test.com/api/adwords/%s/%s/%s?wsdl'
199199
% (namespace, version, service), proxy=https_proxy, cache=self.cache,
200-
timeout=600)
200+
timeout=3600)
201201
self.assertIsInstance(suds_service, googleads.common.SudsServiceProxy)
202202

203203
# Use the default server and https_proxy.
@@ -208,7 +208,7 @@ def testGetService_success(self):
208208
mock_client.assert_called_once_with(
209209
'https://adwords.google.com/api/adwords/%s/%s/%s?wsdl'
210210
% (namespace, version, service), proxy=None, cache=self.cache,
211-
timeout=600)
211+
timeout=3600)
212212
self.assertFalse(mock_client.return_value.set_options.called)
213213
self.assertIsInstance(suds_service, googleads.common.SudsServiceProxy)
214214

tests/dfa_test.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,8 @@ def testGetService_success(self):
108108

109109
mock_client.assert_called_once_with(
110110
'https://testing.test.com/%s/api/dfa-api/%s?wsdl'
111-
% (version, service), proxy=https_proxy, cache=self.cache)
111+
% (version, service), proxy=https_proxy, cache=self.cache,
112+
timeout=3600)
112113
self.assertIsInstance(suds_service, googleads.common.SudsServiceProxy)
113114

114115
# Use the default server and https_proxy.
@@ -118,7 +119,7 @@ def testGetService_success(self):
118119

119120
mock_client.assert_called_once_with(
120121
'https://advertisersapi.doubleclick.com/%s/api/dfa-api/%s?wsdl'
121-
% (version, service), proxy=None, cache=self.cache)
122+
% (version, service), proxy=None, cache=self.cache, timeout=3600)
122123
self.assertFalse(mock_client.return_value.set_options.called)
123124
self.assertIsInstance(suds_service, googleads.common.SudsServiceProxy)
124125

tests/dfp_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def testGetService_success(self):
100100
mock_client.assert_called_once_with(
101101
'https://testing.test.com/apis/ads/publisher/%s/%s?wsdl'
102102
% (self.version, service), proxy=https_proxy, cache=self.cache,
103-
timeout=600)
103+
timeout=3600)
104104
self.assertIsInstance(suds_service, googleads.common.SudsServiceProxy)
105105

106106
# Use the default server and https proxy.
@@ -111,7 +111,7 @@ def testGetService_success(self):
111111
mock_client.assert_called_once_with(
112112
'https://ads.google.com/apis/ads/publisher/%s/%s?wsdl'
113113
% (self.version, service), proxy=None, cache=self.cache,
114-
timeout=600)
114+
timeout=3600)
115115
self.assertFalse(mock_client.return_value.set_options.called)
116116
self.assertIsInstance(suds_service, googleads.common.SudsServiceProxy)
117117

0 commit comments

Comments
 (0)