gapic: replace CloseIdleConnections with nil setter (#694)

Author: noahdietz

internal/gengapic/genrest.go

@@ -149,7 +149,8 @@ func (g *generator) restClientUtilities(serv *descriptor.ServiceDescriptorProto,
 	p("// Close closes the connection to the API service. The user should invoke this when")
 	p("// the client is no longer required.")
 	p("func (c *%s) Close() error {", lowcaseServName)
-	p("    c.httpClient.CloseIdleConnections()")
+	p("    // Replace httpClient with nil to force cleanup.")
+	p("    c.httpClient = nil")
 	p("    return nil")
 	p("}")
 	p("")

internal/gengapic/testdata/deprecated_client_init.want

@@ -176,7 +176,8 @@ func (c *restClient) setGoogleClientInfo(keyval ...string) {
 // Close closes the connection to the API service. The user should invoke this when
 // the client is no longer required.
 func (c *restClient) Close() error {
-	c.httpClient.CloseIdleConnections()
+	// Replace httpClient with nil to force cleanup.
+	c.httpClient = nil
 	return nil
 }
 

internal/gengapic/testdata/empty_client_init.want

@@ -170,7 +170,8 @@ func (c *restClient) setGoogleClientInfo(keyval ...string) {
 // Close closes the connection to the API service. The user should invoke this when
 // the client is no longer required.
 func (c *restClient) Close() error {
-	c.httpClient.CloseIdleConnections()
+	// Replace httpClient with nil to force cleanup.
+	c.httpClient = nil
 	return nil
 }
 

internal/gengapic/testdata/foo_rest_client_init.want

@@ -114,7 +114,8 @@ func (c *fooRESTClient) setGoogleClientInfo(keyval ...string) {
 // Close closes the connection to the API service. The user should invoke this when
 // the client is no longer required.
 func (c *fooRESTClient) Close() error {
-	c.httpClient.CloseIdleConnections()
+	// Replace httpClient with nil to force cleanup.
+	c.httpClient = nil
 	return nil
 }