Skip to content

Generator adds iterator.Done check where iterator is not defined in gapic-showcase #1648

@aandreassa

Description

@aandreassa

The go_cli plugin is incorrectly adding a code block to check for iterator.Done in the generated file cmd/gapic-showcase/search-blurbs.go. This causes a compilation error because the iterator variable is not defined in that context. This is only an issue for that specific file.

PR reproducing the issue: googleapis/gapic-showcase#1597

Steps to reproduce

  1. Updated dependencies as shown in feat: update dependencies and regenerate clients gapic-showcase#1597
  2. Followed steps in for regenerating
  3. Code doesn't compile due to iterator variable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions