-
Notifications
You must be signed in to change notification settings - Fork 57
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
The go_cli plugin is incorrectly adding a code block to check for iterator.Done in the generated file cmd/gapic-showcase/search-blurbs.go. This causes a compilation error because the iterator variable is not defined in that context. This is only an issue for that specific file.
PR reproducing the issue: googleapis/gapic-showcase#1597
Steps to reproduce
- Updated dependencies as shown in feat: update dependencies and regenerate clients gapic-showcase#1597
- Followed steps in for regenerating
- Code doesn't compile due to iterator variable.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.