Skip to content

Commit 8b1a236

Browse files
authored
fix: fix wrapper gem tests by stubbing the stub_logger method (#1132)
1 parent 2fdb857 commit 8b1a236

File tree

5 files changed

+16
-1
lines changed

5 files changed

+16
-1
lines changed

gapic-generator-cloud/templates/cloud/wrapper_gem/client_test.erb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ class <%= gem.namespace %>::ClientConstructionMinitest < Minitest::Test
2020
def universe_domain
2121
"example.com"
2222
end
23+
24+
def stub_logger
25+
nil
26+
end
2327
end
2428

2529
<%- start_line_spacer -%>

gapic-generator/lib/gapic/model/service/nonstandard_lro_provider.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ def initialize service_full_name,
114114
operation_err_code_field,
115115
operation_err_msg_field,
116116
operation_response_fields
117-
118117
@service_full_name = service_full_name
119118
@polling_method_name = polling_method_name
120119
@lro_object_full_name = lro_object_full_name

shared/output/cloud/compute_small_wrapper/test/google/cloud/compute/client_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ def endpoint
3030
def universe_domain
3131
"example.com"
3232
end
33+
34+
def stub_logger
35+
nil
36+
end
3337
end
3438

3539
def test_addresses_rest

shared/output/cloud/language_wrapper/test/google/cloud/language/client_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@ def endpoint
3131
def universe_domain
3232
"example.com"
3333
end
34+
35+
def stub_logger
36+
nil
37+
end
3438
end
3539

3640
def test_language_service_grpc

shared/output/cloud/secretmanager_wrapper/test/google/cloud/secret_manager/client_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ def endpoint
3030
def universe_domain
3131
"example.com"
3232
end
33+
34+
def stub_logger
35+
nil
36+
end
3337
end
3438

3539
def test_secret_manager_service_grpc

0 commit comments

Comments
 (0)