test(bigquery): validate maximumBytesBilled

Author: Deeven-Seru

internal/sources/bigquery/bigquery.go

@@ -90,7 +90,7 @@ type Config struct {
 	ImpersonateServiceAccount string              `yaml:"impersonateServiceAccount"`
 	Scopes                    StringOrStringSlice `yaml:"scopes"`
 	MaxQueryResultRows        int                 `yaml:"maxQueryResultRows"`
-	MaximumBytesBilled        int64               `yaml:"maximumBytesBilled"`
+	MaximumBytesBilled        int64               `yaml:"maximumBytesBilled" validate:"gte=0"`
 }
 
 // StringOrStringSlice is a custom type that can unmarshal both a single string

internal/sources/bigquery/bigquery_test.go

@@ -299,6 +299,17 @@ func TestFailParseFromYaml(t *testing.T) {
 			`,
 			err: "error unmarshaling sources: unable to parse source \"my-instance\" as \"bigquery\": Key: 'Config.Project' Error:Field validation for 'Project' failed on the 'required' tag",
 		},
+		{
+			desc: "negative maximum bytes billed",
+			in: `
+			kind: sources
+			name: my-instance
+			type: bigquery
+			project: my-project
+			maximumBytesBilled: -1
+			`,
+			err: "error unmarshaling sources: unable to parse source \"my-instance\" as \"bigquery\": [1:21] Key: 'Config.MaximumBytesBilled' Error:Field validation for 'MaximumBytesBilled' failed on the 'gte' tag\n>  1 | maximumBytesBilled: -1\n                           ^\n   2 | name: my-instance\n   3 | project: my-project\n   4 | type: bigquery",
+		},
 	}
 	for _, tc := range tcs {
 		t.Run(tc.desc, func(t *testing.T) {
@@ -386,7 +397,7 @@ func TestInitialize_MaximumBytesBilled(t *testing.T) {
 				Name:           "test-default",
 				Type:           bigquery.SourceType,
 				Project:        "test-project",
-				UseClientOAuth: true,
+				UseClientOAuth: "true",
 			},
 			want: 0,
 		},
@@ -396,7 +407,7 @@ func TestInitialize_MaximumBytesBilled(t *testing.T) {
 				Name:               "test-configured",
 				Type:               bigquery.SourceType,
 				Project:            "test-project",
-				UseClientOAuth:     true,
+				UseClientOAuth:     "true",
 				MaximumBytesBilled: 10737418240,
 			},
 			want: 10737418240,