chore(deps): update module google.golang.org/adk to v1#2870
chore(deps): update module google.golang.org/adk to v1#2870renovate-bot wants to merge 3 commits intogoogleapis:mainfrom
Conversation
|
/gcbrun |
trusted-contributions-gcf
bot
added
the
tests: run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version to 1.25.0 and upgrades several dependencies across the documentation's Go examples, including a major version bump for google.golang.org/adk to v1.0.0. A critical issue was identified where this upgrade introduces breaking API changes—specifically to the runner.Run function—that will cause existing example code to fail compilation. Feedback was provided to update the affected logic to use the new iterator-based API.
| require ( | ||
| github.com/googleapis/mcp-toolbox-sdk-go v0.5.1 | ||
| google.golang.org/adk v0.3.0 | ||
| google.golang.org/adk v1.0.0 |
There was a problem hiding this comment.
This major version upgrade of google.golang.org/adk to v1.0.0 introduces breaking API changes that will cause the example in agent.go to fail to compile.
The runner.Run function now returns a Go iterator that yields both an event and an error, and the structure of the agent.Event has changed. The example in docs/en/documentation/configuration/pre-post-processing/go/adk/agent.go needs to be updated to use the new API.
Please replace lines 143-154 in agent.go with the following corrected implementation:
fmt.Print("AI: ")
for event, err := range r.Run(ctx, userID, sess.ID(), userMsg, agent.RunConfig{
StreamingMode: streamingMode,
}) {
if err != nil {
fmt.Printf("\nAGENT_ERROR: %v\n", err)
continue
}
if event != nil && event.LLMResponse != nil && event.LLMResponse.Content != nil {
for _, p := range event.LLMResponse.Content.Parts {
if streamingMode != agent.StreamingModeSSE || event.LLMResponse.Partial {
fmt.Print(p.Text)
}
}
}
}Since agent.go is not part of this pull request's changes, I'm adding this comment here. Please apply the fix to agent.go to resolve the compilation error.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
dishaprakash
added
the
do not merge
4 participants
This PR contains the following updates:
v0.3.0→v1.0.0Release Notes
google/adk-go (google.golang.org/adk)
v1.0.0Compare Source
What's Changed
New Contributors
Full Changelog: google/adk-go@v0.6.0...v1.0.0
v0.6.0Compare Source
What's Changed
generateRequestConfirmationEventcreates events with empty ID by @dannovikov in #588New Contributors
Full Changelog: google/adk-go@v0.5.0...v0.6.0
v0.5.0Compare Source
What's Changed
call_llmspans after adding semconv tracing by @pawel-maciejczek in #556New Contributors
Full Changelog: google/adk-go@v0.4.0...v0.5.0
v0.4.0Compare Source
New major features
note: adk docs will be updated with Go examples
What's Changed
958c8d6by @caglar10ur in #491New Contributors
Full Changelog: google/adk-go@v0.3.0...v0.4.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.