Skip to content

Commit f4c1ac6

Browse files
authored
fix: remove dep hacks for old cycle deps (#2908)
I believe our dep cycle issues should have been fixed in #2907. Verified issue in #2543 is fixed with this change. Fixes: #2559
1 parent 73ee833 commit f4c1ac6

File tree

4 files changed

+3
-14
lines changed

4 files changed

+3
-14
lines changed

doc.go

-8
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,3 @@
143143
// // Do something with the response
144144
// fmt.Println(op.Response)
145145
package api
146-
147-
import (
148-
// Force dependency on main module to ensure it is unambiguous during
149-
// module resolution.
150-
// See: https://github.com/googleapis/google-api-go-client/issues/2559.
151-
_ "cloud.google.com/go/civil"
152-
_ "google.golang.org/genproto/googleapis/type/datetime"
153-
)

go.mod

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ module google.golang.org/api
33
go 1.21
44

55
require (
6-
cloud.google.com/go v0.116.0
76
cloud.google.com/go/auth v0.12.1
87
cloud.google.com/go/auth/oauth2adapt v0.2.6
98
cloud.google.com/go/compute/metadata v0.5.2
@@ -18,7 +17,6 @@ require (
1817
golang.org/x/oauth2 v0.24.0
1918
golang.org/x/sync v0.10.0
2019
golang.org/x/time v0.8.0
21-
google.golang.org/genproto v0.0.0-20241206012308-a4fef0638583
2220
google.golang.org/genproto/googleapis/bytestream v0.0.0-20241206012308-a4fef0638583
2321
google.golang.org/genproto/googleapis/rpc v0.0.0-20241206012308-a4fef0638583
2422
google.golang.org/grpc v1.67.1
@@ -35,4 +33,5 @@ require (
3533
golang.org/x/crypto v0.30.0 // indirect
3634
golang.org/x/sys v0.28.0 // indirect
3735
golang.org/x/text v0.21.0 // indirect
36+
google.golang.org/genproto/googleapis/api v0.0.0-20241118233622-e639e219e697 // indirect
3837
)

go.sum

-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
cloud.google.com/go v0.116.0 h1:B3fRrSDkLRt5qSHWe40ERJvhvnQwdZiHu0bJOpldweE=
2-
cloud.google.com/go v0.116.0/go.mod h1:cEPSRWPzZEswwdr9BxE6ChEn01dWlTaF05LiC2Xs70U=
31
cloud.google.com/go/auth v0.12.1 h1:n2Bj25BUMM0nvE9D2XLTiImanwZhO3DkfWSYS/SAJP4=
42
cloud.google.com/go/auth v0.12.1/go.mod h1:BFMu+TNpF3DmvfBO9ClqTR/SiqVIm7LukKF9mbendF4=
53
cloud.google.com/go/auth/oauth2adapt v0.2.6 h1:V6a6XDu2lTwPZWOawrAa9HUK+DB2zfJyTuciBG5hFkU=
@@ -53,8 +51,6 @@ golang.org/x/text v0.21.0 h1:zyQAAkrwaneQ066sspRyJaG9VNi/YJ1NfzcGB3hZ/qo=
5351
golang.org/x/text v0.21.0/go.mod h1:4IBbMaMmOPCJ8SecivzSH54+73PCFmPWxNTLm+vZkEQ=
5452
golang.org/x/time v0.8.0 h1:9i3RxcPv3PZnitoVGMPDKZSq1xW1gK1Xy3ArNOGZfEg=
5553
golang.org/x/time v0.8.0/go.mod h1:3BpzKBy/shNhVucY/MWOyx10tF3SFh9QdLuxbVysPQM=
56-
google.golang.org/genproto v0.0.0-20241206012308-a4fef0638583 h1:pjPnE7Rv3PAwHISLRJhA3HQTnM2uu5qcnroxTkRb5G8=
57-
google.golang.org/genproto v0.0.0-20241206012308-a4fef0638583/go.mod h1:dW27OyXi0Ph+N43jeCWMFC86aTT5VgdeQtOSf0Hehdw=
5854
google.golang.org/genproto/googleapis/api v0.0.0-20241118233622-e639e219e697 h1:pgr/4QbFyktUv9CtQ/Fq4gzEE6/Xs7iCXbktaGzLHbQ=
5955
google.golang.org/genproto/googleapis/api v0.0.0-20241118233622-e639e219e697/go.mod h1:+D9ySVjN8nY8YCVjc5O7PZDIdZporIDY3KaGfJunh88=
6056
google.golang.org/genproto/googleapis/bytestream v0.0.0-20241206012308-a4fef0638583 h1:QNxhiucJGWLF/fFpnyTIk8GdEGTa6tUC7/JYG7VN3XU=

go.work.sum

+2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMT
44
cloud.google.com/go v0.110.2/go.mod h1:k04UEeEtb6ZBRTv3dZz4CeJC3jKGxyhl0sAiVVquxiw=
55
cloud.google.com/go v0.112.0 h1:tpFCD7hpHFlQ8yPwT3x+QeXqc2T6+n6T+hmABHfDUSM=
66
cloud.google.com/go v0.112.0/go.mod h1:3jEEVwZ/MHU4djK5t5RHuKOA/GbLddgTdVubX1qnPD4=
7+
cloud.google.com/go v0.112.2 h1:ZaGT6LiG7dBzi6zNOvVZwacaXlmf3lRqnC4DQzqyRQw=
8+
cloud.google.com/go v0.112.2/go.mod h1:iEqjp//KquGIJV/m+Pk3xecgKNhV+ry+vVTsy4TbDms=
79
cloud.google.com/go/accessapproval v1.7.5/go.mod h1:g88i1ok5dvQ9XJsxpUInWWvUBrIZhyPDPbk4T01OoJ0=
810
cloud.google.com/go/accessapproval v1.7.11/go.mod h1:KGK3+CLDWm4BvjN0wFtZqdFUGhxlTvTF6PhAwQJGL4M=
911
cloud.google.com/go/accessapproval v1.8.0/go.mod h1:ycc7qSIXOrH6gGOGQsuBwpRZw3QhZLi0OWeej3rA5Mg=

0 commit comments

Comments
 (0)