Skip to content

Commit bd465c9

Browse files
authored
fix: Signet client subclasses no longer make the update! method private (#516)
1 parent 2d7671d commit bd465c9

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

lib/googleauth/compute_engine.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,6 @@ def fetch_access_token _options = {}
154154
end
155155
end
156156

157-
private
158-
159157
# Destructively updates these credentials.
160158
#
161159
# This method is called by `Signet::OAuth2::Client`'s constructor
@@ -177,6 +175,8 @@ def update! options = {}
177175
self
178176
end
179177

178+
private
179+
180180
def log_fetch_query
181181
if token_type == :id_token
182182
logger&.info do

lib/googleauth/service_account.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,6 @@ def needs_access_token?
136136
super && !enable_self_signed_jwt?
137137
end
138138

139-
private
140-
141139
# Destructively updates these credentials
142140
#
143141
# This method is called by `Signet::OAuth2::Client`'s constructor
@@ -164,6 +162,8 @@ def update! options = {}
164162
self
165163
end
166164

165+
private
166+
167167
def apply_self_signed_jwt! a_hash
168168
# Use the ServiceAccountJwtHeaderCredentials using the same cred values
169169
cred_json = {

lib/googleauth/user_refresh.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,6 @@ def includes_scope? required_scope
135135
missing_scope.empty?
136136
end
137137

138-
private
139-
140138
# Destructively updates these credentials
141139
#
142140
# This method is called by `Signet::OAuth2::Client`'s constructor

0 commit comments

Comments
 (0)