Commit 4a68e10
committed
fix(bigtable): address ingestMetadata review nits
- Drop the paragraph in ingestMetadata's doc that recounted the pre-
race-fix code (stashed MD on the attempt, csAttempt.finish vs
transport reader collision, issue #20152 link). The comment now
reads forward-only.
- Add a nested comment on the peerInfoExtracted latch explaining why
the gate is peerInfo != nil rather than the err == nil pattern used
for locationExtracted: extractPeerInfo returns (nil, nil) on missing
header (not an error), so gating on err == nil alone would latch on
the header call and kill the trailer fallback.
No behaviour change.
Verified:
go build ./... → clean
go vet ./bigtable/internal/metrics/... → clean
go test -race -count=1 ./bigtable/internal/metrics/... → pass1 parent 05d910a commit 4a68e10
1 file changed
Lines changed: 6 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
531 | 531 | | |
532 | 532 | | |
533 | 533 | | |
534 | | - | |
535 | | - | |
536 | | - | |
537 | | - | |
538 | | - | |
539 | | - | |
540 | | - | |
541 | | - | |
542 | 534 | | |
543 | 535 | | |
544 | 536 | | |
| |||
594 | 586 | | |
595 | 587 | | |
596 | 588 | | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
597 | 595 | | |
598 | 596 | | |
599 | 597 | | |
| |||
0 commit comments