Revert changes to bigframes/noxfile.py to match main

Author: chalmerlowe

packages/bigframes/noxfile.py

@@ -20,6 +20,7 @@
 import multiprocessing
 import os
 import pathlib
+import re
 import shutil
 import time
 from typing import Dict, List
@@ -61,6 +62,7 @@
     "pytest-cov",
     "pytest-timeout",
 ]
+UNIT_TEST_EXTERNAL_DEPENDENCIES: List[str] = []
 UNIT_TEST_DEPENDENCIES: List[str] = []
 UNIT_TEST_EXTRAS: List[str] = ["tests"]
 UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {
@@ -93,7 +95,7 @@
 SYSTEM_TEST_EXTERNAL_DEPENDENCIES = [
     "google-cloud-bigquery",
 ]
-SYSTEM_TEST_EXTRAS: List[str] = ["tests"]
+SYSTEM_TEST_EXTRAS: List[str] = []
 SYSTEM_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {
     # Make sure we leave some versions without "extras" so we know those
     # dependencies are actually optional.
@@ -255,10 +257,14 @@ def run_unit(session, install_test_extra):
 
 
 @nox.session(python=ALL_PYTHON)
-def unit(session):
+@nox.parametrize("test_extra", [True, False])
+def unit(session, test_extra):
     if session.python in ("3.7", "3.8", "3.9"):
         session.skip("Python 3.9 and below are not supported")
-    run_unit(session, install_test_extra=True)
+    if test_extra:
+        run_unit(session, install_test_extra=test_extra)
+    else:
+        unit_noextras(session)
 
 
 @nox.session(python=ALL_PYTHON[-1])
@@ -361,14 +367,15 @@ def run_system(
 @nox.session(python="3.12")
 def system(session: nox.sessions.Session):
     """Run the system test suite."""
-    # TODO(https://github.com/googleapis/google-cloud-python/issues/16489): Restore system test once this bug is fixed
+    if session.python in ("3.7", "3.8", "3.9"):
+        session.skip("Python 3.9 and below are not supported")
+
     run_system(
         session=session,
         prefix_name="system",
         test_folder=os.path.join("tests", "system", "small"),
         check_cov=True,
     )
-    # session.skip("Temporarily skip system test")
 
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
@@ -385,6 +392,10 @@ def system_noextras(session: nox.sessions.Session):
 @nox.session(python="3.12")
 def doctest(session: nox.sessions.Session):
     """Run the system test suite."""
+    session.skip(
+        "Temporary skip to enable a PR merge. Remove skip as part of closing https://github.com/googleapis/google-cloud-python/issues/16489"
+    )
+
     run_system(
         session=session,
         prefix_name="doctest",
@@ -440,6 +451,10 @@ def cover(session):
     This outputs the coverage report aggregating coverage from the test runs
     (including system test runs), and then erases coverage data.
     """
+    # TODO: Remove this skip when the issue is resolved.
+    # https://github.com/googleapis/google-cloud-python/issues/16635
+    session.skip("Temporarily skip coverage session")
+
     session.install("coverage", "pytest-cov")
 
     # Create a coverage report that includes only the product code.
@@ -921,69 +936,129 @@ def cleanup(session):
 
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
-def core_deps_from_source(session):
+@nox.parametrize(
+    "protobuf_implementation",
+    ["python", "upb"],
+)
+def core_deps_from_source(session, protobuf_implementation):
     """Run all tests with core dependencies installed from source
     rather than pulling the dependencies from PyPI.
     """
-    # TODO(https://github.com/googleapis/google-cloud-python/issues/16014):
-    # Add core deps from source tests
-    session.skip("Core deps from source tests are not yet supported")
 
+    # Install all dependencies
+    session.install("-e", ".")
 
-@nox.session(python=DEFAULT_PYTHON_VERSION)
+    # Install dependencies for the unit test environment
+    unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
+    session.install(*unit_deps_all)
+
+    # Install dependencies for the system test environment
+    system_deps_all = (
+        SYSTEM_TEST_STANDARD_DEPENDENCIES
+        + SYSTEM_TEST_EXTERNAL_DEPENDENCIES
+        + SYSTEM_TEST_EXTRAS
+    )
+    session.install(*system_deps_all)
+
+    # Because we test minimum dependency versions on the minimum Python
+    # version, the first version we test with in the unit tests sessions has a
+    # constraints file containing all dependencies and extras.
+    with open(
+        CURRENT_DIRECTORY / "testing" / "constraints-3.10.txt",
+        encoding="utf-8",
+    ) as constraints_file:
+        constraints_text = constraints_file.read()
+
+    # Ignore leading whitespace and comment lines.
+    # Fiona fails to build on GitHub CI because gdal-config is missing and no Python 3.14 wheels are available.
+    constraints_deps = [
+        match.group(1)
+        for match in re.finditer(
+            r"^\s*(\S+)(?===\S+)", constraints_text, flags=re.MULTILINE
+        )
+        if match.group(1) != "fiona"
+    ]
+
+    # Install dependencies specified in `testing/constraints-X.txt`.
+    session.install(*constraints_deps)
+
+    # TODO(https://github.com/googleapis/gapic-generator-python/issues/2358): `grpcio` and
+    # `grpcio-status` should be added to the list below so that they are installed from source,
+    # rather than PyPI.
+    # TODO(https://github.com/googleapis/gapic-generator-python/issues/2357): `protobuf` should be
+    # added to the list below so that it is installed from source, rather than PyPI
+    # Note: If a dependency is added to the `core_dependencies_from_source` list,
+    # the `prerel_deps` list in the `prerelease_deps` nox session should also be updated.
+    core_dependencies_from_source = [
+        "googleapis-common-protos @ git+https://github.com/googleapis/google-cloud-python#egg=googleapis-common-protos&subdirectory=packages/googleapis-common-protos",
+        "google-api-core @ git+https://github.com/googleapis/google-cloud-python#egg=google-api-core&subdirectory=packages/google-api-core",
+        "google-auth @ git+https://github.com/googleapis/google-cloud-python#egg=google-auth&subdirectory=packages/google-auth",
+        "grpc-google-iam-v1 @ git+https://github.com/googleapis/google-cloud-python#egg=grpc-google-iam-v1&subdirectory=packages/grpc-google-iam-v1",
+        "proto-plus @ git+https://github.com/googleapis/google-cloud-python#egg=proto-plus&subdirectory=packages/proto-plus",
+    ]
+
+    for dep in core_dependencies_from_source:
+        session.install(dep, "--no-deps", "--ignore-installed")
+        print(f"Installed {dep}")
+
+    session.run(
+        "py.test",
+        "tests/unit",
+        env={
+            "PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION": protobuf_implementation,
+        },
+    )
+
+
+@nox.session(python=ALL_PYTHON[-1])
 def prerelease_deps(session):
     """Run all tests with prerelease versions of dependencies installed."""
     # TODO(https://github.com/googleapis/google-cloud-python/issues/16014):
     # Add prerelease deps tests
-    session.skip("prerelease deps tests are not yet supported")
+    unit_prerelease(session)
+    system_prerelease(session)
 
 
-@nox.session(python=DEFAULT_PYTHON_VERSION)
+# NOTE: this is based on mypy session that came directly from the bigframes split repo
+# the split repo used 3.10, the monorepo uses 3.14
+@nox.session(python="3.14")
 def mypy(session):
-    """Run the type checker."""
-    # TODO(https://github.com/googleapis/google-cloud-python/issues/16014):
-    # Add mypy tests previously used mypy session (below) failed to run in the monorepo
-    session.skip("mypy tests are not yet supported")
-
-
-# @nox.session(python=ALL_PYTHON)
-# def mypy(session):
-#     """Run type checks with mypy."""
-#     # Editable mode is not compatible with mypy when there are multiple
-#     # package directories. See:
-#     # https://github.com/python/mypy/issues/10564#issuecomment-851687749
-#     session.install(".")
-
-#     # Just install the dependencies' type info directly, since "mypy --install-types"
-#     # might require an additional pass.
-#     deps = (
-#         set(
-#             [
-#                 MYPY_VERSION,
-#                 # TODO: update to latest pandas-stubs once we resolve bigframes issues.
-#                 "pandas-stubs<=2.2.3.241126",
-#                 "types-protobuf",
-#                 "types-python-dateutil",
-#                 "types-requests",
-#                 "types-setuptools",
-#                 "types-tabulate",
-#                 "types-PyYAML",
-#                 "polars",
-#                 "anywidget",
-#             ]
-#         )
-#         | set(SYSTEM_TEST_STANDARD_DEPENDENCIES)
-#         | set(UNIT_TEST_STANDARD_DEPENDENCIES)
-#     )
-
-#     session.install(*deps)
-#     shutil.rmtree(".mypy_cache", ignore_errors=True)
-#     session.run(
-#         "mypy",
-#         "bigframes",
-#         os.path.join("tests", "system"),
-#         os.path.join("tests", "unit"),
-#         "--check-untyped-defs",
-#         "--explicit-package-bases",
-#         '--exclude="^third_party"',
-#     )
+    """Run type checks with mypy."""
+    # Editable mode is not compatible with mypy when there are multiple
+    # package directories. See:
+    # https://github.com/python/mypy/issues/10564#issuecomment-851687749
+    session.install(".")
+
+    # Just install the dependencies' type info directly, since "mypy --install-types"
+    # might require an additional pass.
+    deps = (
+        set(
+            [
+                MYPY_VERSION,
+                # TODO: update to latest pandas-stubs once we resolve bigframes issues.
+                "pandas-stubs<=2.2.3.241126",
+                "types-protobuf",
+                "types-python-dateutil",
+                "types-requests",
+                "types-setuptools",
+                "types-tabulate",
+                "types-PyYAML",
+                "polars",
+                "anywidget",
+            ]
+        )
+        | set(SYSTEM_TEST_STANDARD_DEPENDENCIES)
+        | set(UNIT_TEST_STANDARD_DEPENDENCIES)
+    )
+
+    session.install(*deps)
+    shutil.rmtree(".mypy_cache", ignore_errors=True)
+    session.run(
+        "mypy",
+        "bigframes",
+        os.path.join("tests", "system"),
+        os.path.join("tests", "unit"),
+        "--check-untyped-defs",
+        "--explicit-package-bases",
+        '--exclude="^third_party"',
+    )