Merge branch 'main' into obj-metadata-in-aaow

Author: nidhiii-27

.github/CODEOWNERS

@@ -2,14 +2,45 @@
 # This file controls who is tagged for review for any given pull request.
 #
 # To add a new package or team:
-# 1. Add the directory path below the default catch-all rule (`*`).
-# 2. Append the new team AFTER the default cloud-sdk teams.
+# 1. Add any new team names to the list of teams below. This allows us to
+#    quickly view which teams are present in this repo.
+# 2. Add the package path and corresponding team
 # 3. The new team must have "Write" access to google-cloud-python
 #    See go/cloud-sdk-googleapis#aod for instructions on requesting
 #    access to modify repo settings.
 
-# Default owner for all directories not owned by others
-*                                             @googleapis/cloud-sdk-python-team @googleapis/cloud-sdk-librarian-team
+# List of teams in this repo
+# - @googleapis/aion-team
+# - @googleapis/bigquery-dataframe-team
+# - @googleapis/bigquery-team
+# - @googleapis/bigtable-team
+# - @googleapis/cloud-sdk-auth-team
+# - @googleapis/cloud-sdk-python-team
+# - @googleapis/dkp-team
+# - @googleapis/firestore-team
+# - @googleapis/gcs-team
+# - @googleapis/pubsub-team
+# - @googleapis/spanner-team
 
-/packages/bigframes/                          @googleapis/cloud-sdk-python-team @googleapis/cloud-sdk-librarian-team @googleapis/bigquery-dataframe-team
-/packages/google-auth/                        @googleapis/cloud-sdk-python-team @googleapis/cloud-sdk-librarian-team @googleapis/cloud-sdk-auth-team @googleapis/aion-team
+# As per the above, the following list is only used for notifications, not for approvals.
+# Googlers see b/477912165 and corresponding design doc
+
+# Catch all. @googleapis/cloud-sdk-python-team is notified on every change for packages not owned by other teams.
+*                                             @googleapis/cloud-sdk-python-team
+
+/packages/bigframes/                          @googleapis/bigquery-team @googleapis/bigquery-dataframe-team
+/packages/bigquery-magics/                    @googleapis/bigquery-team @googleapis/bigquery-dataframe-team
+/packages/db-dtypes/                          @googleapis/bigquery-team @googleapis/bigquery-dataframe-team
+/packages/django-google-spanner/              @googleapis/spanner-team
+/packages/gcp-sphinx-docfx-yaml/              @googleapis/dkp-team
+/packages/google-auth/                        @googleapis/cloud-sdk-auth-team @googleapis/aion-team
+/packages/google-cloud-bigquery*/             @googleapis/bigquery-team @googleapis/bigquery-dataframe-team
+/packages/google-cloud-bigtable/              @googleapis/bigtable-team
+/packages/google-cloud-firestore/             @googleapis/firestore-team
+/packages/google-cloud-pubsub/                @googleapis/pubsub-team
+/packages/google-cloud-spanner/               @googleapis/spanner-team
+/packages/google-cloud-storage/               @googleapis/gcs-team
+/packages/google-resumable-media/             @googleapis/gcs-team @googleapis/bigquery-team @googleapis/bigquery-dataframe-team
+/packages/pandas-gbq/                         @googleapis/bigquery-team @googleapis/bigquery-dataframe-team
+/packages/sqlalchemy-bigquery/                @googleapis/bigquery-team @googleapis/bigquery-dataframe-team
+/packages/sqlalchemy-spanner/                 @googleapis/spanner-team

.github/workflows/docs.yml

@@ -13,66 +13,7 @@ permissions:
   contents: read
 
 jobs:
-  # The two jobs "docs" and "docsfx" are marked as required checks
-  # (and reset as such periodically) elsewhere in our
-  # automation. Since we don't want to block non-release PRs on docs
-  # failures, we want these checks to always show up as succeeded for
-  # those PRs. For release PRs, we do want the checks to run and block
-  # merge on failure.
-  #
-  # We accomplish this by using an "if:" conditional. Jobs
-  # thus skipped via a conditional (i.e. a false condition) show as
-  # having succeeded. See:
-  # https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
-  #
-  # Since we want advance notice of docs errors, we also have two
-  # corresponding non-required checks, the jobs "docs-warnings" and
-  # "docfx-warnings", that run for all non-release PRs (i.e., when the
-  # "docs" and "docfx" jobs don't run).
-  #
-  #
-  # PLEASE ENSURE THE FOLLOWING AT ALL TIMES:
-  #
-  # - the "*-warnings" checks remain NON-REQUIRED in the repo
-  #   settings.
-  #
-  # - the steps for the jobs "docs" and "docfx" are identical to the
-  #   ones in "docs-warnings" and "docfx-warnings", respectively.  We
-  #   will be able to avoid config duplication once GitHub actions
-  #   support YAML anchors (see
-  #   https://github.com/actions/runner/issues/1182)
   docs:
-    if: github.actor == 'release-please[bot]'
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v6
-      # Use a fetch-depth of 2 to avoid error `fatal: origin/main...HEAD: no merge base`
-      # See https://github.com/googleapis/google-cloud-python/issues/12013
-      # and https://github.com/actions/checkout#checkout-head.
-      with:
-        fetch-depth: 2
-    - name: Setup Python
-      uses: actions/setup-python@v6
-      with:
-        python-version: "3.10"
-    - name: Install nox
-      run: |
-        python -m pip install --upgrade setuptools pip wheel
-        python -m pip install nox
-    - name: Run docs
-      env:
-        BUILD_TYPE: presubmit
-        TARGET_BRANCH: ${{ github.base_ref || github.event.merge_group.base_ref }}
-        TEST_TYPE: docs
-        # TODO(https://github.com/googleapis/google-cloud-python/issues/13775): Specify `PY_VERSION` rather than relying on the default python version of the nox session.
-        PY_VERSION: "unused"
-      run: |
-        ci/run_conditional_tests.sh
-  docs-warnings:    
-    if: github.actor != 'release-please[bot]'
-    name: "Docs warnings: will block release"
-    continue-on-error: true
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
@@ -100,37 +41,6 @@ jobs:
       run: |
         ci/run_conditional_tests.sh
   docfx:
-    if: github.actor == 'release-please[bot]'
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v6
-      # Use a fetch-depth of 2 to avoid error `fatal: origin/main...HEAD: no merge base`
-      # See https://github.com/googleapis/google-cloud-python/issues/12013
-      # and https://github.com/actions/checkout#checkout-head.
-      with:
-        fetch-depth: 2
-    - name: Setup Python
-      uses: actions/setup-python@v6
-      with:
-        python-version: "3.10"
-    - name: Install nox
-      run: |
-        python -m pip install --upgrade setuptools pip wheel
-        python -m pip install nox
-    - name: Run docfx
-      env:
-        BUILD_TYPE: presubmit
-        TARGET_BRANCH: ${{ github.base_ref || github.event.merge_group.base_ref }}
-        TEST_TYPE: docfx
-        # TODO(https://github.com/googleapis/google-cloud-python/issues/13775): Specify `PY_VERSION` rather than relying on the default python version of the nox session.
-        PY_VERSION: "unused"
-      run: |
-        ci/run_conditional_tests.sh
-  docfx-warnings:
-    if: github.actor != 'release-please[bot]'
-    name: "Docfx warnings: will block release"
-    continue-on-error: true
     runs-on: ubuntu-latest
     steps:
     - name: Checkout

.gitignore

@@ -66,3 +66,9 @@ pylintrc.test
 
 # Ruff cache
 .ruff_cache
+
+# Bazel (created in packages/gapic-generator)
+bazel-bin
+bazel-gapic-generator
+bazel-out
+bazel-testlogs

.kokoro/continuous/continuous-bigframes.cfg

@@ -0,0 +1,7 @@
+# Format: //devtools/kokoro/config/proto/build.proto
+
+# Only run these nox sessions.
+env_vars: {
+    key: "NOX_SESSION"
+    value: "e2e load system_prerelease notebook system_noextras"
+}

.kokoro/presubmit/presubmit-doctest-bigframes.cfg

@@ -0,0 +1,12 @@
+# Format: //devtools/kokoro/config/proto/build.proto
+
+# Only run this nox session.
+env_vars: {
+    key: "NOX_SESSION"
+    value: "cleanup doctest"
+}
+
+env_vars: {
+    key: "GOOGLE_CLOUD_PROJECT"
+    value: "bigframes-testing"
+}

.kokoro/system.sh

@@ -43,7 +43,8 @@ run_package_test() {
   local PROJECT_ID
   local GOOGLE_APPLICATION_CREDENTIALS
   local NOX_FILE
-  local NOX_SESSION
+  # Inherit NOX_SESSION from environment to allow configs (like prerelease.cfg) to pass it in
+  local NOX_SESSION="${NOX_SESSION}"
 
   echo "------------------------------------------------------------"
   echo "Configuring environment for: ${package_name}"
@@ -66,7 +67,8 @@ run_package_test() {
       PROJECT_ID=$(cat "${KOKORO_GFILE_DIR}/project-id.json")
       GOOGLE_APPLICATION_CREDENTIALS="${KOKORO_GFILE_DIR}/service-account.json"
       NOX_FILE="noxfile.py"
-      NOX_SESSION="system-3.12"
+      # Use inherited NOX_SESSION if set, otherwise fallback to system-3.12
+      NOX_SESSION="${NOX_SESSION:-system-3.12}"
       ;;
   esac
 
@@ -96,15 +98,16 @@ packages_with_system_tests=(
   "google-cloud-datastore"
   "google-cloud-dns"
   "google-cloud-error-reporting"
-  "sqlalchemy-spanner"
   "google-cloud-firestore"
   "google-cloud-logging"
   "google-cloud-ndb"
   "google-cloud-pubsub"
   "google-cloud-spanner"
+  "google-cloud-storage"
   "google-cloud-testutils"
-  "sqlalchemy-bigquery"
   "pandas-gbq"
+  "sqlalchemy-bigquery"
+  "sqlalchemy-spanner"
 )
 
 # A file for running system tests
@@ -138,11 +141,11 @@ for path in `find 'packages' \
   package_modified=$(git diff "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" -- ${files_to_check} | wc -l)
   set -e
 
-  if [[ "${package_modified}" -gt 0 ]]; then
+  if [[ "${package_modified}" -gt 0 || "$KOKORO_BUILD_ARTIFACTS_SUBDIR" == *"continuous"* ]]; then
       # Call the function - its internal exports won't affect the next loop
       run_package_test "$package_name" || RETVAL=$?
   else
-      echo "No changes in ${package_name}, skipping."
+      echo "No changes in ${package_name} and not a continuous build, skipping."
   fi
 done
 exit ${RETVAL}