-
Notifications
You must be signed in to change notification settings - Fork 1.7k
add more types to google.cloud.firestore.BaseDocumentReference #16502
Copy link
Copy link
Open
Labels
api: firestoreIssues related to the Firestore API.Issues related to the Firestore API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
Determine this is the right repository
- I determined this is the correct repository in which to report this feature request.
Summary of the feature request
many methods of {Async,}DocumentReference (such as id, path, collections, …) are missing some type information, making my strict type checker complain about using Any (type used when not documented). having theses types in the codebase directly will help ensure that we are correctly using theses references.
Desired code experience
_: int = reference.pathExpected results
lint fails with "Incompatible types in assignment"
API client name and version
No response
Use case
catch errors sooner
Additional context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
api: firestoreIssues related to the Firestore API.Issues related to the Firestore API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.