cleanup(auth): remove test_credentials() (#3257)

This is now redundant, `anonymous::Builder` can do the same thing.

This is non-breaking. The function was `#[doc(hidden)]`, and those are
not part of the public API. In any case, we bumped the version for other
reasons

Author: coryan

src/auth/src/credentials.rs

@@ -576,39 +576,13 @@ fn adc_well_known_path() -> Option<String> {
 #[cfg_attr(test, mutants::skip)]
 #[doc(hidden)]
 pub mod testing {
-    use super::{CacheableResource, EntityTag};
+    use super::CacheableResource;
     use crate::Result;
     use crate::credentials::Credentials;
     use crate::credentials::dynamic::CredentialsProvider;
     use http::{Extensions, HeaderMap};
     use std::sync::Arc;
 
-    /// A simple credentials implementation to use in tests where authentication does not matter.
-    ///
-    /// Always returns a "Bearer" token, with "test-only-token" as the value.
-    pub fn test_credentials() -> Credentials {
-        Credentials {
-            inner: Arc::from(TestCredentials {}),
-        }
-    }
-
-    #[derive(Debug)]
-    struct TestCredentials;
-
-    #[async_trait::async_trait]
-    impl CredentialsProvider for TestCredentials {
-        async fn headers(&self, _extensions: Extensions) -> Result<CacheableResource<HeaderMap>> {
-            Ok(CacheableResource::New {
-                entity_tag: EntityTag::default(),
-                data: HeaderMap::new(),
-            })
-        }
-
-        async fn universe_domain(&self) -> Option<String> {
-            None
-        }
-    }
-
     /// A simple credentials implementation to use in tests.
     ///
     /// Always return an error in `headers()`.

src/auth/tests/credentials.rs

@@ -26,7 +26,6 @@ mod tests {
     use google_cloud_auth::credentials::EntityTag;
     use google_cloud_auth::credentials::mds::Builder as MdsBuilder;
     use google_cloud_auth::credentials::service_account::Builder as ServiceAccountBuilder;
-    use google_cloud_auth::credentials::testing::test_credentials;
     use google_cloud_auth::credentials::user_account::Builder as UserAccountCredentialBuilder;
     use google_cloud_auth::credentials::{
         Builder as AccessTokenCredentialBuilder, CacheableResource, Credentials,
@@ -495,23 +494,6 @@ mod tests {
         Ok(())
     }
 
-    #[tokio::test]
-    async fn testing_credentials() -> Result<()> {
-        let creds = test_credentials();
-        let cached_headers = creds.headers(Extensions::new()).await?;
-        match cached_headers {
-            CacheableResource::New { entity_tag, data } => {
-                assert_eq!(entity_tag, EntityTag::default());
-                assert!(data.is_empty());
-            }
-            CacheableResource::NotModified => {
-                unreachable!("Expecting a header to be present");
-            }
-        };
-        assert_eq!(creds.universe_domain().await, None);
-        Ok(())
-    }
-
     #[tokio::test]
     async fn get_mds_credentials_from_builder() -> Result<()> {
         let test_quota_project = "test-quota-project";

src/gax-internal/tests/grpc_client_polling.rs

@@ -14,12 +14,15 @@
 
 #[cfg(all(test, feature = "_internal-grpc-client"))]
 mod tests {
-    use auth::credentials::testing::test_credentials;
     use gax::polling_state::PollingState;
     use grpc_server::{builder, start_echo_server};
 
     type TestResult = Result<(), Box<dyn std::error::Error>>;
 
+    fn test_credentials() -> auth::credentials::Credentials {
+        auth::credentials::anonymous::Builder::new().build()
+    }
+
     /// A test policy, the only interesting bit is the name, which is included
     /// in debug messages and used in the tests.
     #[derive(Debug)]
@@ -90,7 +93,7 @@ mod tests {
     async fn request_options_polling_policies() -> TestResult {
         let (endpoint, _server) = start_echo_server().await?;
         let client = builder(endpoint)
-            .with_credentials(auth::credentials::testing::test_credentials())
+            .with_credentials(test_credentials())
             .with_polling_error_policy(TestErrorPolicy {
                 _name: "client-polling-error".to_string(),
             })

src/gax-internal/tests/grpc_retry_loop.rs

@@ -14,13 +14,16 @@
 
 #[cfg(all(test, feature = "_internal-grpc-client"))]
 mod tests {
-    use auth::credentials::testing::test_credentials;
     use gax::options::*;
     use gax::retry_policy::{Aip194Strict, RetryPolicyExt};
     use google_cloud_gax_internal::grpc;
     use grpc_server::google::test::v1::EchoResponse;
     use grpc_server::{builder, google, start_fixed_responses};
 
+    fn test_credentials() -> auth::credentials::Credentials {
+        auth::credentials::anonymous::Builder::new().build()
+    }
+
     #[tokio::test]
     async fn no_retry_immediate_success() -> anyhow::Result<()> {
         let (endpoint, _server) = start_fixed_responses(vec![success()]).await?;

src/gax-internal/tests/grpc_simple_request.rs

@@ -14,11 +14,14 @@
 
 #[cfg(all(test, feature = "_internal-grpc-client"))]
 mod tests {
-    use auth::credentials::testing::test_credentials;
     use gax::options::*;
     use google_cloud_gax_internal::grpc;
     use grpc_server::{builder, google, start_echo_server};
 
+    fn test_credentials() -> auth::credentials::Credentials {
+        auth::credentials::anonymous::Builder::new().build()
+    }
+
     #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
     async fn default_endpoint() -> anyhow::Result<()> {
         let (endpoint, _server) = start_echo_server().await?;

src/gax-internal/tests/grpc_timeout.rs

@@ -15,7 +15,6 @@
 #[cfg(all(test, feature = "_internal-grpc-client"))]
 mod tests {
     use anyhow::Result;
-    use auth::credentials::testing::test_credentials;
     use gax::options::*;
     use gax::retry_policy::{AlwaysRetry, RetryPolicyExt};
     use gax::retry_state::RetryState;
@@ -25,6 +24,10 @@ mod tests {
     use std::sync::{Arc, Mutex};
     use std::time::Duration;
 
+    fn test_credentials() -> auth::credentials::Credentials {
+        auth::credentials::anonymous::Builder::new().build()
+    }
+
     #[tokio::test(start_paused = true)]
     async fn test_no_timeout() -> Result<()> {
         let (endpoint, server) = start_echo_server().await?;

src/gax-internal/tests/grpc_user_agent.rs

@@ -18,11 +18,15 @@ mod test {
     use google_cloud_gax_internal::grpc;
     use grpc_server::{builder, google, start_echo_server};
 
+    fn test_credentials() -> auth::credentials::Credentials {
+        auth::credentials::anonymous::Builder::new().build()
+    }
+
     #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
     async fn test_user_agent() -> anyhow::Result<()> {
         let (endpoint, _server) = start_echo_server().await?;
         let client = builder(endpoint)
-            .with_credentials(auth::credentials::testing::test_credentials())
+            .with_credentials(test_credentials())
             .build()
             .await?;
 

src/gax-internal/tests/http_client_errors.rs

@@ -19,13 +19,17 @@ mod tests {
 
     type Result<T> = std::result::Result<T, Box<dyn std::error::Error>>;
 
+    fn test_credentials() -> auth::credentials::Credentials {
+        auth::credentials::anonymous::Builder::new().build()
+    }
+
     #[tokio::test(flavor = "multi_thread", worker_threads = 2)]
     async fn test_error_with_status() -> Result<()> {
         use serde_json::Value;
         let (endpoint, _server) = echo_server::start().await?;
 
         let client = echo_server::builder(endpoint)
-            .with_credentials(auth::credentials::testing::test_credentials())
+            .with_credentials(test_credentials())
             .build()
             .await?;
 

src/gax-internal/tests/http_client_polling.rs

@@ -18,6 +18,10 @@ mod tests {
 
     type TestResult = Result<(), Box<dyn std::error::Error>>;
 
+    fn test_credentials() -> auth::credentials::Credentials {
+        auth::credentials::anonymous::Builder::new().build()
+    }
+
     /// A test policy, the only interesting bit is the name, which is included
     /// in debug messages and used in the tests.
     #[derive(Debug)]
@@ -48,7 +52,7 @@ mod tests {
     async fn default_polling_policies() -> TestResult {
         let (endpoint, _server) = echo_server::start().await?;
         let client = echo_server::builder(endpoint)
-            .with_credentials(auth::credentials::testing::test_credentials())
+            .with_credentials(test_credentials())
             .build()
             .await?;
 
@@ -64,7 +68,7 @@ mod tests {
     async fn client_config_polling_policies() -> TestResult {
         let (endpoint, _server) = echo_server::start().await?;
         let client = echo_server::builder(endpoint)
-            .with_credentials(auth::credentials::testing::test_credentials())
+            .with_credentials(test_credentials())
             .with_polling_error_policy(TestErrorPolicy {
                 _name: "client-polling-error".to_string(),
             })
@@ -89,7 +93,7 @@ mod tests {
     async fn request_options_polling_policies() -> TestResult {
         let (endpoint, _server) = echo_server::start().await?;
         let client = echo_server::builder(endpoint)
-            .with_credentials(auth::credentials::testing::test_credentials())
+            .with_credentials(test_credentials())
             .with_polling_error_policy(TestErrorPolicy {
                 _name: "client-polling-error".to_string(),
             })

src/gax-internal/tests/http_metadata.rs

@@ -59,8 +59,9 @@ mod tests {
     }
 
     fn test_config() -> ClientConfig {
+        let cred = auth::credentials::anonymous::Builder::new().build();
         ClientConfig {
-            cred: auth::credentials::testing::test_credentials().into(),
+            cred: cred.into(),
             ..Default::default()
         }
     }