docs(auth): id token user guide #3762
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3762 +/- ##
==========================================
- Coverage 96.16% 96.14% -0.02%
==========================================
Files 146 146
Lines 5682 5682
==========================================
- Hits 5464 5463 -1
- Misses 218 219 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
This PR does not look ready, too many strange things.
| - [Setting up Rust on Cloud Shell](setting_up_rust_on_cloud_shell.md) | ||
| - [How to initialize a client](initialize_a_client.md) | ||
| - [Authentication](credentials.md) | ||
| - [Override the authentication credentials](credentials/override.md) |
There was a problem hiding this comment.
Maybe. I was grouping all the "product neutral guides" together, including all the configuration changes to clients.
| // [START rust_auth_id_verify_token_parameters] ANCHOR: verify_id_token_parameters | ||
| // # Parameters | ||
| // * `token`: The ID token string to verify. | ||
| // * `audience`: The expected audience of the ID token. | ||
| // [END rust_auth_id_verify_token_parameters] ANCHOR_END: verify_id_token_parameters |
There was a problem hiding this comment.
move this to before the function definition.
alvarowolfx
left a comment
alvarowolfx
left a comment
There was a problem hiding this comment.
addressed review comments. Some extra files were due to some mismatch between mdformat running on my cloudtop and also mdbook not liking when you rename files and move things around.
| // [START rust_auth_id_verify_token_parameters] ANCHOR: verify_id_token_parameters | ||
| // # Parameters | ||
| // * `token`: The ID token string to verify. | ||
| // * `audience`: The expected audience of the ID token. | ||
| // [END rust_auth_id_verify_token_parameters] ANCHOR_END: verify_id_token_parameters |
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Blocking for now. The documentation is publish on each release, which would be bad for these changes because the features are not enabled by default. We should queue these changes until the features are enabled too.
alvarowolfx
added
the
do not merge
2 participants
Towards #3449