Skip to content

Conversation

@alvarowolfx
Copy link
Collaborator

@alvarowolfx alvarowolfx commented Nov 10, 2025

Allow to specify if customers want to include email in the token claims when using ADC flow. This will enable email claim on sources that have to be set up for that, like MDS and Impersonated flows.

Towards #3449

@alvarowolfx alvarowolfx requested review from a team as code owners November 10, 2025 20:05
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.16%. Comparing base (1980f0d) to head (39abba2).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/auth/src/credentials/idtoken.rs 86.36% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3763      +/-   ##
==========================================
+ Coverage   96.11%   96.16%   +0.04%     
==========================================
  Files         146      146              
  Lines        5665     5682      +17     
==========================================
+ Hits         5445     5464      +19     
+ Misses        220      218       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coryan
coryan previously approved these changes Nov 11, 2025
@alvarowolfx alvarowolfx changed the title Impl(auth): id token adc flow should include email Impl(auth): id token adc flow should allow including email Nov 11, 2025
alvarowolfx added a commit that referenced this pull request Nov 13, 2025
Inline with changes on #3763, in which the ADC flow will have a method
to just enable email claims.

Towards #3449
@alvarowolfx
Copy link
Collaborator Author

will be updated after some PR like #3792 and #3789

Copy link
Collaborator

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes that you need to do. A question around larger changes for testability.

@alvarowolfx alvarowolfx changed the title Impl(auth): id token adc flow should allow including email impl(auth): id token adc flow should allow including email Nov 14, 2025
@alvarowolfx alvarowolfx merged commit f1778ca into googleapis:main Nov 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants