-
Notifications
You must be signed in to change notification settings - Fork 94
impl(auth): id token adc flow should allow including email #3763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl(auth): id token adc flow should allow including email #3763
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3763 +/- ##
==========================================
+ Coverage 96.11% 96.16% +0.04%
==========================================
Files 146 146
Lines 5665 5682 +17
==========================================
+ Hits 5445 5464 +19
+ Misses 220 218 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes that you need to do. A question around larger changes for testability.
Allow to specify if customers want to include email in the token claims when using ADC flow. This will enable email claim on sources that have to be set up for that, like MDS and Impersonated flows.
Towards #3449