WIP - draft code with very few tests #3787
Draft
+1,685
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3787 +/- ##
==========================================
- Coverage 96.15% 94.60% -1.56%
==========================================
Files 146 157 +11
Lines 5649 5946 +297
==========================================
+ Hits 5432 5625 +193
- Misses 217 321 +104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
force-pushed
the
draft09-storage-bidi-streaming-reads
branch
from
1bd9697 to
f7c5d51
Compare
I am going to use `ReadRange` and `Range` (renamed to `RequestedRange`) more widely in the crate.
Implement some types to normalize and update read ranges in bidi streaming reads. We need to model both requested ranges (which include ranges with a negative offset) and ranges updated from the first (and subsequent) responses. The latter always have positive offsets.
coryan
force-pushed
the
draft09-storage-bidi-streaming-reads
branch
from
f7c5d51 to
bfb48b8
Compare
This type holds the pending remaining range (for resends) and a `mpsc` sender (to deliver data and errors to the application). The worker task will keep a collection of these objects and deliver data and errors to the application through them.
Rename some things
coryan
force-pushed
the
draft09-storage-bidi-streaming-reads
branch
from
bfb48b8 to
ada04c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.