impl(storage): normalize and update read ranges #3805
+618
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3805 +/- ##
==========================================
+ Coverage 96.13% 96.16% +0.03%
==========================================
Files 146 149 +3
Lines 5664 5743 +79
==========================================
+ Hits 5445 5523 +78
- Misses 219 220 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Implement some types to normalize and update read ranges in bidi streaming reads. We need to model both requested ranges (which include ranges with a negative offset) and ranges updated from the first (and subsequent) responses. The latter always have positive offsets.
coryan
force-pushed
the
pr03-impl-storage-bidi-remaining-range
branch
from
a95a972 to
4debe98
Compare
Collaborator
Author
|
/FYI @cjc25 @BenWhitehead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement some types to normalize and update read ranges in bidi streaming reads. We need to model both requested ranges (which include ranges with a negative offset) and ranges updated from the first (and subsequent) responses. The latter always have positive offsets.
Part of the work for #3626