Skip to content

Conversation

@suzmue
Copy link
Collaborator

@suzmue suzmue commented Nov 13, 2025

This may be too eager, but we bumped the version of longrunning in the workspace Cargo.toml and many of these crates depend on features in the upgraded version.

There are 122 files containing "longrunning.workspace". 119 of those are changed in this PR. The other files are the user-guide-samples, integration-tests, and google-cloud-showcase-v1beta1 crates, and these are marked as publish=false so did not need a change.

For #3793

@suzmue suzmue requested a review from a team as a code owner November 13, 2025 23:11
@dbolduc
Copy link
Member

dbolduc commented Nov 13, 2025

The .sidekick.toml are the source of truth for the versions. Gotta do them too.

Aside: I forget why we skip formatting on generated things. It might be simpler if we didn't?

git ls-files -z -- '*.toml' ':!:testdata/**' ':!:**/generated/**' | \
xargs -0 taplo fmt

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@80b732a). Learn more about missing BASE report.
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3806   +/-   ##
=======================================
  Coverage        ?   96.12%           
=======================================
  Files           ?      146           
  Lines           ?     5658           
  Branches        ?        0           
=======================================
  Hits            ?     5439           
  Misses          ?      219           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suzmue
Copy link
Collaborator Author

suzmue commented Nov 13, 2025

The .sidekick.toml are the source of truth for the versions. Gotta do them too.

Right thank you 🙏

This may be too eager, but we bumped the version of longrunning in the workspace Cargo.toml and many of these crates depend on features in the upgraded version.

There are 122 files containing "longrunning.workspace". 119 of those are changed in this PR. The other files are the user-guide-samples, integration-tests, and google-cloud-showcase-v1beta1 crates, and these are marked as publish=false so did not need a change.

For googleapis#3793
[package]
name = "google-cloud-cloudsecuritycompliance-v1"
version = "2.1.0"
version = "2.1.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@suzmue suzmue merged commit acbee59 into googleapis:main Nov 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants