Skip to content

Commit 02aae0e

Browse files
committed
feat: Migrate to JUnit 5 and add parallel test execution
1 parent 7198340 commit 02aae0e

File tree

91 files changed

+358
-330
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

91 files changed

+358
-330
lines changed

google-cloud-bigquery/pom.xml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,13 @@
162162
<scope>test</scope>
163163
</dependency>
164164
<dependency>
165-
<groupId>junit</groupId>
166-
<artifactId>junit</artifactId>
165+
<groupId>org.junit.jupiter</groupId>
166+
<artifactId>junit-jupiter</artifactId>
167+
<scope>test</scope>
168+
</dependency>
169+
<dependency>
170+
<groupId>org.mockito</groupId>
171+
<artifactId>mockito-junit-jupiter</artifactId>
167172
<scope>test</scope>
168173
</dependency>
169174
<dependency>

google-cloud-bigquery/src/test/java/MetadataCacheStatsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@
1616

1717
package com.google.cloud.bigquery;
1818

19-
import static org.junit.Assert.assertEquals;
19+
import static org.junit.jupiter.api.Assertions.assertEquals;
2020

2121
import com.google.api.services.bigquery.model.MetadataCacheStatistics;
2222
import com.google.common.collect.ImmutableList;
2323
import com.google.common.truth.Truth;
2424
import java.util.List;
2525
import java.util.stream.Collectors;
26-
import org.junit.Test;
26+
import org.junit.jupiter.api.Test;
2727

2828
public class MetadataCacheStatsTest {
2929
private static List<com.google.api.services.bigquery.model.TableMetadataCacheUsage>

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/AclTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package com.google.cloud.bigquery;
1818

19-
import static org.junit.Assert.assertEquals;
19+
import static org.junit.jupiter.api.Assertions.assertEquals;
2020

2121
import com.google.api.services.bigquery.model.Dataset;
2222
import com.google.cloud.bigquery.Acl.DatasetAclEntity;
@@ -31,7 +31,7 @@
3131
import com.google.cloud.bigquery.Acl.View;
3232
import com.google.common.collect.ImmutableList;
3333
import java.util.List;
34-
import org.junit.Test;
34+
import org.junit.jupiter.api.Test;
3535

3636
public class AclTest {
3737

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/AnnotationsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@
1717
package com.google.cloud.bigquery;
1818

1919
import static com.google.common.truth.Truth.assertThat;
20-
import static org.junit.Assert.fail;
20+
import static org.junit.jupiter.api.Assertions.fail;
2121

2222
import com.google.api.client.util.Data;
2323
import java.util.Collections;
2424
import java.util.HashMap;
2525
import java.util.Map;
26-
import org.junit.Test;
26+
import org.junit.jupiter.api.Test;
2727

2828
public class AnnotationsTest {
2929
@Test

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/AvroOptionsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
package com.google.cloud.bigquery;
1818

19-
import static org.junit.Assert.assertEquals;
19+
import static org.junit.jupiter.api.Assertions.assertEquals;
2020

21-
import org.junit.Test;
21+
import org.junit.jupiter.api.Test;
2222

2323
public class AvroOptionsTest {
2424

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/BigLakeConfigurationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
package com.google.cloud.bigquery;
1818

19-
import static org.junit.Assert.assertEquals;
19+
import static org.junit.jupiter.api.Assertions.assertEquals;
2020

21-
import org.junit.Test;
21+
import org.junit.jupiter.api.Test;
2222

2323
public class BigLakeConfigurationTest {
2424

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/BigQueryErrorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
package com.google.cloud.bigquery;
1818

19-
import static org.junit.Assert.assertEquals;
19+
import static org.junit.jupiter.api.Assertions.assertEquals;
2020

21-
import org.junit.Test;
21+
import org.junit.jupiter.api.Test;
2222

2323
public class BigQueryErrorTest {
2424

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/BigQueryExceptionTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616

1717
package com.google.cloud.bigquery;
1818

19-
import static org.junit.Assert.assertEquals;
20-
import static org.junit.Assert.assertFalse;
21-
import static org.junit.Assert.assertNull;
22-
import static org.junit.Assert.assertSame;
23-
import static org.junit.Assert.assertTrue;
19+
import static org.junit.jupiter.api.Assertions.assertEquals;
20+
import static org.junit.jupiter.api.Assertions.assertFalse;
21+
import static org.junit.jupiter.api.Assertions.assertNull;
22+
import static org.junit.jupiter.api.Assertions.assertSame;
23+
import static org.junit.jupiter.api.Assertions.assertTrue;
2424
import static org.mockito.Mockito.doReturn;
2525
import static org.mockito.Mockito.doThrow;
2626
import static org.mockito.Mockito.mock;
@@ -40,11 +40,11 @@
4040
import java.net.SocketTimeoutException;
4141
import java.util.HashMap;
4242
import java.util.Map;
43-
import org.junit.Test;
44-
import org.junit.runner.RunWith;
45-
import org.mockito.junit.MockitoJUnitRunner;
43+
import org.junit.jupiter.api.Test;
44+
import org.junit.jupiter.api.extension.ExtendWith;
45+
import org.mockito.junit.jupiter.MockitoExtension;
4646

47-
@RunWith(MockitoJUnitRunner.class)
47+
@ExtendWith(MockitoExtension.class)
4848
public class BigQueryExceptionTest {
4949

5050
@Test

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/BigQueryImplTest.java

Lines changed: 24 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,19 @@
4747
import java.util.Collections;
4848
import java.util.List;
4949
import java.util.Map;
50-
import org.junit.Assert;
51-
import org.junit.Before;
52-
import org.junit.Test;
53-
import org.junit.runner.RunWith;
50+
import org.junit.jupiter.api.Assertions;
51+
import org.junit.jupiter.api.BeforeEach;
52+
import org.junit.jupiter.api.Test;
53+
import org.junit.jupiter.api.extension.ExtendWith;
5454
import org.mockito.ArgumentCaptor;
5555
import org.mockito.Captor;
5656
import org.mockito.Mockito;
57-
import org.mockito.junit.MockitoJUnitRunner;
57+
import org.mockito.junit.jupiter.MockitoExtension;
58+
import org.mockito.junit.jupiter.MockitoSettings;
59+
import org.mockito.quality.Strictness;
5860

59-
@RunWith(MockitoJUnitRunner.class)
61+
@ExtendWith(MockitoExtension.class)
62+
@MockitoSettings(strictness = Strictness.LENIENT)
6063
public class BigQueryImplTest {
6164

6265
private static final String PROJECT = "project";
@@ -537,7 +540,7 @@ private BigQueryOptions createBigQueryOptionsForProjectWithLocation(
537540
.build();
538541
}
539542

540-
@Before
543+
@BeforeEach
541544
public void setUp() {
542545
rpcFactoryMock = mock(BigQueryRpcFactory.class);
543546
bigqueryRpcMock = mock(HttpBigQueryRpc.class);
@@ -631,9 +634,9 @@ public void testGetDatasetNotFoundWhenThrowIsEnabled() throws IOException {
631634
bigquery = options.getService();
632635
try {
633636
bigquery.getDataset("dataset-not-found");
634-
Assert.fail();
637+
Assertions.fail();
635638
} catch (BigQueryException ex) {
636-
Assert.assertNotNull(ex.getMessage());
639+
Assertions.assertNotNull(ex.getMessage());
637640
}
638641
verify(bigqueryRpcMock)
639642
.getDatasetSkipExceptionTranslation(PROJECT, "dataset-not-found", EMPTY_RPC_OPTIONS);
@@ -979,9 +982,9 @@ public void testGetTableNotFoundWhenThrowIsEnabled() throws IOException {
979982
bigquery = options.getService();
980983
try {
981984
bigquery.getTable(DATASET, "table-not-found");
982-
Assert.fail();
985+
Assertions.fail();
983986
} catch (BigQueryException ex) {
984-
Assert.assertNotNull(ex.getMessage());
987+
Assertions.assertNotNull(ex.getMessage());
985988
}
986989
verify(bigqueryRpcMock)
987990
.getTableSkipExceptionTranslation(PROJECT, DATASET, "table-not-found", EMPTY_RPC_OPTIONS);
@@ -1468,9 +1471,9 @@ public TableDataInsertAllRequest.Rows apply(RowToInsert rowToInsert) {
14681471
.getService();
14691472
try {
14701473
bigquery.insertAll(request);
1471-
Assert.fail();
1474+
Assertions.fail();
14721475
} catch (BigQueryException ex) {
1473-
Assert.assertNotNull(ex.getMessage());
1476+
Assertions.assertNotNull(ex.getMessage());
14741477
}
14751478
verify(bigqueryRpcMock).insertAll(PROJECT, DATASET, TABLE, requestPb);
14761479
}
@@ -2055,9 +2058,9 @@ public void testGetJobNotFoundWhenThrowIsEnabled() throws IOException {
20552058
bigquery = options.getService();
20562059
try {
20572060
bigquery.getJob("job-not-found");
2058-
Assert.fail();
2061+
Assertions.fail();
20592062
} catch (BigQueryException ex) {
2060-
Assert.assertNotNull(ex.getMessage());
2063+
Assertions.assertNotNull(ex.getMessage());
20612064
}
20622065
verify(bigqueryRpcMock)
20632066
.getJobSkipExceptionTranslation(PROJECT, "job-not-found", null, EMPTY_RPC_OPTIONS);
@@ -2783,9 +2786,9 @@ public void testNonRetryableException() throws IOException {
27832786
.getService();
27842787
try {
27852788
bigquery.getDataset(DatasetId.of(DATASET));
2786-
Assert.fail();
2789+
Assertions.fail();
27872790
} catch (BigQueryException ex) {
2788-
Assert.assertEquals(exceptionMessage, ex.getMessage());
2791+
Assertions.assertEquals(exceptionMessage, ex.getMessage());
27892792
}
27902793
verify(bigqueryRpcMock).getDatasetSkipExceptionTranslation(PROJECT, DATASET, EMPTY_RPC_OPTIONS);
27912794
}
@@ -2802,9 +2805,9 @@ public void testRuntimeException() throws IOException {
28022805
.getService();
28032806
try {
28042807
bigquery.getDataset(DATASET);
2805-
Assert.fail();
2808+
Assertions.fail();
28062809
} catch (BigQueryException ex) {
2807-
Assert.assertTrue(ex.getMessage().endsWith(exceptionMessage));
2810+
Assertions.assertTrue(ex.getMessage().endsWith(exceptionMessage));
28082811
}
28092812
verify(bigqueryRpcMock).getDatasetSkipExceptionTranslation(PROJECT, DATASET, EMPTY_RPC_OPTIONS);
28102813
}
@@ -2818,9 +2821,9 @@ public void testQueryDryRun() throws Exception {
28182821
.build()
28192822
.getService()
28202823
.query(QueryJobConfiguration.newBuilder("foo").setDryRun(true).build());
2821-
Assert.fail();
2824+
Assertions.fail();
28222825
} catch (UnsupportedOperationException ex) {
2823-
Assert.assertNotNull(ex.getMessage());
2826+
Assertions.assertNotNull(ex.getMessage());
28242827
}
28252828
}
28262829

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/BigQueryOptionsTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,28 +16,28 @@
1616

1717
package com.google.cloud.bigquery;
1818

19-
import static org.junit.Assert.assertEquals;
19+
import static org.junit.jupiter.api.Assertions.assertEquals;
2020
import static org.junit.Assert.assertFalse;
21-
import static org.junit.Assert.assertNotNull;
21+
import static org.junit.jupiter.api.Assertions.assertNotNull;
2222
import static org.junit.Assert.assertTrue;
2323

2424
import com.google.cloud.TransportOptions;
25-
import org.junit.Assert;
26-
import org.junit.Test;
27-
import org.junit.runner.RunWith;
25+
import org.junit.jupiter.api.Assertions;
26+
import org.junit.jupiter.api.Test;
27+
import org.junit.jupiter.api.extension.ExtendWith;
2828
import org.mockito.Mockito;
29-
import org.mockito.junit.MockitoJUnitRunner;
29+
import org.mockito.junit.jupiter.MockitoExtension;
3030

31-
@RunWith(MockitoJUnitRunner.class)
31+
@ExtendWith(MockitoExtension.class)
3232
public class BigQueryOptionsTest {
3333

3434
@Test
3535
public void testInvalidTransport() {
3636
try {
3737
BigQueryOptions.newBuilder().setTransportOptions(Mockito.mock(TransportOptions.class));
38-
Assert.fail();
38+
Assertions.fail();
3939
} catch (IllegalArgumentException expected) {
40-
Assert.assertNotNull(expected.getMessage());
40+
Assertions.assertNotNull(expected.getMessage());
4141
}
4242
}
4343

0 commit comments

Comments
 (0)