Skip to content

Commit 92a4dff

Browse files
authored
Revert "feat(internal/repometadata): assign Transport in FromLibrary (#4916)"
This reverts commit 15ad6c4.
1 parent f60925d commit 92a4dff

File tree

5 files changed

+6
-11
lines changed

5 files changed

+6
-11
lines changed

internal/librarian/java/repometadata.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ func deriveRepoMetadata(cfg *config.Config, library *config.Library, googleapisD
9999
ProductDocumentation: sharedMetadata.ProductDocumentation,
100100
APIDescription: sharedMetadata.APIDescription,
101101
ReleaseLevel: sharedMetadata.ReleaseLevel,
102-
Transport: sharedMetadata.Transport,
103102
Language: config.LanguageJava,
104103
Repo: sharedMetadata.Repo,
105104
RepoShort: fmt.Sprintf("%s-%s", config.LanguageJava, library.Name),
@@ -157,5 +156,11 @@ func deriveRepoMetadata(cfg *config.Config, library *config.Library, googleapisD
157156
artifactID := parts[len(parts)-1]
158157
metadata.ClientDocumentation = fmt.Sprintf("https://cloud.google.com/java/docs/reference/%s/latest/overview", artifactID)
159158
}
159+
// transport
160+
apiCfg, err := serviceconfig.Find(googleapisDir, library.APIs[0].Path, config.LanguageJava)
161+
if err != nil {
162+
return nil, fmt.Errorf("failed to find api config: %w", err)
163+
}
164+
metadata.Transport = apiCfg.RepoMetadataTransport(config.LanguageJava)
160165
return metadata, nil
161166
}

internal/librarian/rust/generate_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,6 @@ func TestCreateRepoMetadata(t *testing.T) {
710710
APIDescription: "Stores sensitive data such as API keys, passwords, and certificates.\nProvides convenience while improving security.",
711711
ReleaseLevel: "stable",
712712
LibraryType: "GAPIC_AUTO",
713-
Transport: "grpc+rest",
714713
},
715714
},
716715
{
@@ -738,7 +737,6 @@ func TestCreateRepoMetadata(t *testing.T) {
738737
APIShortname: "showcase",
739738
ReleaseLevel: "stable",
740739
LibraryType: "GAPIC_AUTO",
741-
Transport: "grpc+rest",
742740
},
743741
},
744742
} {

internal/repometadata/repometadata.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,6 @@ type RepoMetadata struct {
9090

9191
// Repo is the repository name (e.g., "googleapis/google-cloud-rust").
9292
Repo string `json:"repo,omitempty"`
93-
94-
// Transport is the transport protocol
95-
Transport string `json:"transport,omitempty"`
9693
}
9794

9895
// FromLibrary creates a RepoMetadata from a specific library in a
@@ -109,7 +106,6 @@ type RepoMetadata struct {
109106
// - ProductDocumentation
110107
// - ReleaseLevel
111108
// - Repo
112-
// - Transport
113109
//
114110
// Any other fields required by the caller's language should be populated by the
115111
// caller before writing to disk.
@@ -146,7 +142,6 @@ func fromAPI(config *config.Config, api *serviceconfig.API, library *config.Libr
146142
ProductDocumentation: extractBaseProductURL(api.DocumentationURI),
147143
ReleaseLevel: api.ReleaseLevel(config.Language),
148144
Repo: config.Repo,
149-
Transport: api.RepoMetadataTransport(config.Language),
150145
}
151146
}
152147

internal/repometadata/repometadata_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ func TestFromLibrary(t *testing.T) {
4848
APIID: "secretmanager.googleapis.com",
4949
APIShortname: "secretmanager",
5050
APIDescription: "Stores sensitive data such as API keys, passwords, and certificates.\nProvides convenience while improving security.",
51-
Transport: "grpc+rest",
5251
},
5352
},
5453
{
@@ -70,7 +69,6 @@ func TestFromLibrary(t *testing.T) {
7069
APIID: "secretmanager.googleapis.com",
7170
APIShortname: "secretmanager",
7271
APIDescription: "Stores, manages, and secures access to application secrets.",
73-
Transport: "grpc+rest",
7472
},
7573
},
7674
{

internal/sample/repometadata.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,5 @@ func RepoMetadata() *repometadata.RepoMetadata {
3232
NamePretty: "Secret Manager",
3333
ProductDocumentation: "https://cloud.google.com/secret-manager/",
3434
ReleaseLevel: "stable",
35-
Transport: "grpc+rest",
3635
}
3736
}

0 commit comments

Comments
 (0)