fix(sqlcommenter): enforce rfc 3986 percent encoding for spaces

tanujbolisetty · tanujbolisetty · commit 420132abe5ff · 2026-03-31T15:54:22.000-04:00
diff --git a/internal/sqlcommenter/commenter.go b/internal/sqlcommenter/commenter.go
@@ -82,7 +82,7 @@ func agentName() string {
 
 // encode percent-encodes a value according to the SQLCommenter spec (RFC 3986).
 func encode(v string) string {
-	return url.QueryEscape(v)
+	return strings.ReplaceAll(url.QueryEscape(v), "+", "%20")
 }
 
 // AppendComment appends a SQLCommenter comment to sql.  The comment carries the

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ func agentName() string {`
`82`	`82`
`83`	`83`	`// encode percent-encodes a value according to the SQLCommenter spec (RFC 3986).`
`84`	`84`	`func encode(v string) string {`
`85`		`- return url.QueryEscape(v)`
	`85`	`+ return strings.ReplaceAll(url.QueryEscape(v), "+", "%20")`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`// AppendComment appends a SQLCommenter comment to sql. The comment carries the`