Skip to content

Commit 8905e5b

Browse files
authored
fix(tools/looker): address feedback for agent tool (#2834)
## Description Addresses the feedback from the maintainers regarding the `looker-agent` tool.
1 parent bdf0205 commit 8905e5b

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

docs/en/resources/tools/looker/looker-agent.md

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,18 @@ name: agent_manage
2626
type: looker-agent
2727
source: my_looker_source
2828
description: |
29-
Manage Looker AI Agents.
29+
Manage Looker AI Agents. This tool allows you to perform various operations on Looker Agents,
30+
including listing all available agents, retrieving details for a specific agent,
31+
creating a new agent, and deleting an existing one.
32+
33+
Parameters:
34+
- operation (required): The action to perform.
35+
- 'list': Returns a list of all existing agents. No other parameters needed.
36+
- 'get': Retrieves detailed information about a specific agent. Requires 'agent_id'.
37+
- 'create': Creates a new Looker AI Agent. Requires 'name'.
38+
- 'delete': Removes an existing agent. Requires 'agent_id'.
39+
- agent_id (optional): The unique identifier of the agent. Required for 'get' and 'delete' operations.
40+
- name (optional): The display name for the new agent. Required for 'create' operation.
3041
```
3142
3243
## Parameters
@@ -76,11 +87,3 @@ Delete an agent by its ID.
7687

7788
## Dependencies
7889
This tool requires the underlying Looker Go SDK to support the `Agent` API resource (v0.26.6+).
79-
80-
## Reference
81-
82-
| **field** | **type** | **required** | **description** |
83-
|-------------|:--------:|:------------:|----------------------------------------------------|
84-
| type | string | true | Must be "looker-agent". |
85-
| source | string | true | Name of the source the SQL should execute on. |
86-
| description | string | true | Description of the tool that is passed to the LLM. |

internal/tools/looker/lookeragent/lookeragent_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@ func TestParseFromYamlLookerAgent(t *testing.T) {
3838
desc: "basic example",
3939
in: `
4040
kind: tool
41-
name: example_tool
41+
name: agent_manage
4242
type: looker-agent
4343
source: my-instance
4444
description: some description
4545
`,
4646
want: server.ToolConfigs{
47-
"example_tool": lkr.Config{
48-
Name: "example_tool",
47+
"agent_manage": lkr.Config{
48+
Name: "agent_manage",
4949
Type: "looker-agent",
5050
Source: "my-instance",
5151
Description: "some description",

0 commit comments

Comments
 (0)