Skip to content

Commit c93e28d

Browse files
committed
Fix: Address review comments on PR #2958
1 parent f6a5056 commit c93e28d

File tree

8 files changed

+11
-11
lines changed

8 files changed

+11
-11
lines changed

.ci/integration.cloudbuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ steps:
330330
entrypoint: /bin/bash
331331
env:
332332
- "GOPATH=/gopath"
333-
- "DATAPLEX_PROJECT=$PROJECT_ID"
333+
- "KNOWLEDGE_CATALOG_PROJECT=$PROJECT_ID"
334334
- "SERVICE_ACCOUNT_EMAIL=$SERVICE_ACCOUNT_EMAIL"
335335
secretEnv: ["CLIENT_ID"]
336336
volumes:

.github/blunderbuss.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ assign_issues_by:
4444
to:
4545
- 'googleapis/toolbox-cloud-sql-postgres-team'
4646
- labels:
47-
- 'product: dataplex'
47+
- 'product: knowledge-catalog'
4848
to:
4949
- 'googleapis/toolbox-dataplex-team'
5050
- labels:

.github/labels.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,9 @@
120120
- name: 'product: couchbase'
121121
color: 5065c7
122122
description: 'Couchbase'
123-
- name: 'product: dataplex'
123+
- name: 'product: knowledge-catalog'
124124
color: 5065c7
125-
description: 'Dataplex'
125+
description: 'Knowledge Catalog'
126126
- name: 'product: dgraph'
127127
color: 5065c7
128128
description: 'Dgraph'

cmd/internal/config_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1445,7 +1445,7 @@ func TestPrebuiltTools(t *testing.T) {
14451445
t.Setenv("API_KEY", "your_api_key")
14461446

14471447
t.Setenv("BIGQUERY_PROJECT", "your_gcp_project_id")
1448-
t.Setenv("DATAPLEX_PROJECT", "your_gcp_project_id")
1448+
t.Setenv("KNOWLEDGE_CATALOG_PROJECT", "your_gcp_project_id")
14491449
t.Setenv("FIRESTORE_PROJECT", "your_gcp_project_id")
14501450
t.Setenv("FIRESTORE_DATABASE", "your_firestore_db_name")
14511451

docs/KNOWLEDGECATALOG_README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ The Knowledge Catalog MCP server provides the following tools:
5858
The MCP server is configured using environment variables.
5959

6060
```bash
61-
export DATAPLEX_PROJECT="<your-gcp-project-id>"
61+
export KNOWLEDGE_CATALOG_PROJECT="<your-gcp-project-id>"
6262
```
6363

6464
Add the following configuration to your MCP client (e.g., `settings.json` for Gemini CLI, `mcp_config.json` for Antigravity):
@@ -70,7 +70,7 @@ Add the following configuration to your MCP client (e.g., `settings.json` for Ge
7070
"command": "npx",
7171
"args": ["-y", "@toolbox-sdk/server", "--prebuilt", "knowledge-catalog", "--stdio"],
7272
"env": {
73-
"DATAPLEX_PROJECT": "your-project-id"
73+
"KNOWLEDGE_CATALOG_PROJECT": "your-project-id"
7474
}
7575
}
7676
}

docs/en/integrations/knowledge-catalog/prebuilt-configs/knowledge-catalog.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ description: "Details of the Knowledge Catalog(formerly known as Dataplex) prebu
88

99
* `--prebuilt` value: `knowledge-catalog`
1010
* **Environment Variables:**
11-
* `DATAPLEX_PROJECT`: The GCP project ID.
11+
* `KNOWLEDGE_CATALOG_PROJECT`: The GCP project ID.
1212
* **Permissions:**
1313
* **Knowledge Catalog Reader** (`roles/dataplex.viewer`) to search and look up
1414
entries.

internal/prebuiltconfigs/tools/knowledge-catalog.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
sources:
1616
knowledge-catalog-source:
1717
kind: "knowledge-catalog"
18-
project: ${DATAPLEX_PROJECT}
18+
project: ${KNOWLEDGE_CATALOG_PROJECT}
1919

2020
tools:
2121
search_entries:

tests/knowledge-catalog/knowledge_catalog_integration_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,13 @@ var (
4545
KnowledgeCatalogSearchEntriesToolType = "knowledge-catalog-search-entries"
4646
KnowledgeCatalogLookupEntryToolType = "knowledge-catalog-lookup-entry"
4747
KnowledgeCatalogSearchAspectTypesToolType = "knowledge-catalog-search-aspect-types"
48-
KnowledgeCatalogProject = os.Getenv("DATAPLEX_PROJECT")
48+
KnowledgeCatalogProject = os.Getenv("KNOWLEDGE_CATALOG_PROJECT")
4949
)
5050

5151
func getKnowledgeCatalogVars(t *testing.T) map[string]any {
5252
switch "" {
5353
case KnowledgeCatalogProject:
54-
t.Fatal("'DATAPLEX_PROJECT' not set")
54+
t.Fatal("'KNOWLEDGE_CATALOG_PROJECT' not set")
5555
}
5656
return map[string]any{
5757
"type": KnowledgeCatalogSourceType,

0 commit comments

Comments
 (0)