Skip to content

Not updating .release-please-manifest.json #2172

Open
@Lightning00Blade

Description

@Lightning00Blade

We use release-please to create releases for the Puppeteer project. The current structure is a mono repo so we use a configuration file to express this.
This works well for the 3 packages that depend on each other puppeteer, puppeteer-core, and @puppeteer/browsers.
But for the last one @puppeteer/ng-schematics we are seeing issue that the release does not update .release-please-manifest.json.

This can be observed on the latest PR - puppeteer/puppeteer#11543.
If we do merge this PR without updating the manifest manually release-please will open a new one as the version differs with the manifest file. Observed:
Initial - puppeteer/puppeteer#11496
A second one - puppeteer/puppeteer#11508

The issue is not consistent. It doesn't fail all the time as you can see from puppeteer/puppeteer#11488

Environment details

  • GitHub App

Steps to reproduce

  1. Have not reproduced locally, but happy to follow up if instruction are provided.

Metadata

Metadata

Assignees

Labels

priority: p3Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions