-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
It looks like the returned unused instructions are off-by-one.
For example take the following:
- Create a new retry test X with instructions:
map[storage.objects.insert:[return-503-after-257K return-503 return-503 return-503 return-503] - Upload the first 256k chunk, which returns a 200. No test instructions should be used up here.
- Try uploading the next 256k chunk twice. Get 2 503s.
- 2 instructions should be consumed (
return-503-after-257Kandreturn-503)
- 2 instructions should be consumed (
- Get the retry test and inspect the instructions:
map[storage.objects.insert:[return-503 return-503 return-503 return-503]]
Expected: map[storage.objects.insert:[return-503 return-503 return-503]]
I inserted a delay of 30 seconds and saw the same thing.
Note: this is not an issue with http bucket lists.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.