Skip to content

Commit 0f274fb

Browse files
committed
refactor(library): address PR review feedback on build config and dependencies
1 parent 68a5342 commit 0f274fb

2 files changed

Lines changed: 6 additions & 12 deletions

File tree

‎library/build.gradle.kts‎

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,35 +38,29 @@ android {
3838
)
3939
}
4040
}
41-
lint {
42-
abortOnError = false
43-
}
4441
compileOptions {
45-
sourceCompatibility = JavaVersion.VERSION_17
46-
targetCompatibility = JavaVersion.VERSION_17
42+
sourceCompatibility = JavaVersion.VERSION_11
43+
targetCompatibility = JavaVersion.VERSION_11
4744
}
4845
lint {
46+
abortOnError = false
4947
disable += setOf("MissingInflatedId", "OnClick")
5048
sarifOutput = layout.buildDirectory.file("reports/lint-results-debug.sarif").get().asFile
5149
}
5250
kotlin {
5351
compilerOptions {
54-
jvmTarget.set(JvmTarget.JVM_17)
52+
jvmTarget.set(JvmTarget.JVM_11)
5553
javaParameters.set(true)
5654
}
5755
}
5856
}
5957

6058
dependencies {
61-
implementation(libs.appcompat)
62-
implementation(libs.core.ktx)
63-
implementation(libs.material)
6459
implementation(libs.startup.runtime)
6560
implementation(libs.play.services.maps)
6661
testImplementation(libs.junit)
6762
testImplementation(libs.robolectric)
6863
testImplementation(libs.mockk)
69-
testImplementation(libs.espresso.core)
7064
}
7165

7266

‎library/src/test/java/com/example/library/utils/AttributionIdInitializerTest.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
package com.example.library.utils
1717

1818
import android.content.Context
19-
import androidx.test.core.app.ApplicationProvider
2019
import com.example.library.utils.attribution.AttributionIdInitializer
2120
import com.example.library.utils.meta.AttributionId
2221
import com.google.android.gms.maps.MapsApiSettings
@@ -31,6 +30,7 @@ import org.junit.Before
3130
import org.junit.Test
3231
import org.junit.runner.RunWith
3332
import org.robolectric.RobolectricTestRunner
33+
import org.robolectric.RuntimeEnvironment
3434

3535
@RunWith(RobolectricTestRunner::class)
3636
class AttributionIdInitializerTest {
@@ -47,7 +47,7 @@ class AttributionIdInitializerTest {
4747

4848
@Test
4949
fun `create adds internal usage attribution id`() {
50-
val context = ApplicationProvider.getApplicationContext<Context>()
50+
val context: Context = RuntimeEnvironment.getApplication()
5151
val initializer = AttributionIdInitializer()
5252

5353
initializer.create(context)

0 commit comments

Comments
 (0)