chore: remove global deprecated member use ignore rule (#681)

Author: jokerttu

analysis_options.yaml

@@ -28,8 +28,6 @@ analyzer:
   errors:
     # allow self-reference to deprecated members
     deprecated_member_use_from_same_package: ignore
-    # allow deprecated member use in test files and examples
-    deprecated_member_use: ignore
   exclude:
     # Ignore generated files
     - "**/*.g.dart"

example/lib/pages/markers.dart

@@ -315,7 +315,7 @@ class _MarkersPageState extends ExamplePageState<MarkersPage> {
                         borderRadius: BorderRadius.circular(8),
                         boxShadow: <BoxShadow>[
                           BoxShadow(
-                            color: Colors.black.withOpacity(0.2),
+                            color: Colors.black.withValues(alpha: 0.2),
                             blurRadius: 6,
                             offset: const Offset(0, 2),
                           ),

example/patrol_test/shared.dart

@@ -137,9 +137,9 @@ Widget wrapMapView(GoogleMapsMapView mapView) {
 
 Future<void> _acceptTermsAndConditionsDialog(PatrolIntegrationTester $) async {
   if (Platform.isAndroid) {
-    await $.native.tap(Selector(text: 'Got It'));
+    await $.platformAutomator.tap(Selector(text: 'Got It'));
   } else if (Platform.isIOS) {
-    await $.native.tap(Selector(text: 'OK'));
+    await $.platformAutomator.tap(Selector(text: 'OK'));
   } else {
     fail('Unsupported platform: ${Platform.operatingSystem}');
   }
@@ -183,11 +183,11 @@ Future<void> checkLocationDialogAcceptance(PatrolIntegrationTester $) async {
         .locationWhenInUse
         .request();
 
-    if (await $.native.isPermissionDialogVisible(
+    if (await $.platformAutomator.mobile.isPermissionDialogVisible(
       timeout: const Duration(seconds: 5),
     )) {
       // Grant location permission.
-      await $.native.grantPermissionWhenInUse();
+      await $.platformAutomator.mobile.grantPermissionWhenInUse();
     }
 
     // Check that the location permission is granted.

example/patrol_test/t02_session_test.dart

@@ -30,7 +30,7 @@ void main() {
   ) async {
     if (!Platform.isIOS) {
       // Be sure location is enabled.
-      await $.native.enableLocation();
+      await $.platformAutomator.android.enableLocation();
     }
 
     // Grant the location permission.
@@ -59,9 +59,9 @@ void main() {
 
     // Tap ok.
     if (Platform.isAndroid) {
-      await $.native.tap(Selector(text: "Got It"));
+      await $.platformAutomator.tap(Selector(text: "Got It"));
     } else if (Platform.isIOS) {
-      await $.native.tap(Selector(text: "OK"));
+      await $.platformAutomator.tap(Selector(text: "OK"));
     } else {
       fail('Unsupported platform: ${Platform.operatingSystem}');
     }
@@ -112,9 +112,9 @@ void main() {
 
       // Accept driver awareness disclaimer.
       if (Platform.isAndroid) {
-        await $.native.tap(Selector(text: "Got It"));
+        await $.platformAutomator.tap(Selector(text: "Got It"));
       } else if (Platform.isIOS) {
-        await $.native.tap(Selector(text: "OK"));
+        await $.platformAutomator.tap(Selector(text: "OK"));
       } else {
         fail('Unsupported platform: ${Platform.operatingSystem}');
       }
@@ -152,7 +152,7 @@ void main() {
   ) async {
     if (!Platform.isIOS) {
       // Be sure location is enabled.
-      await $.native.enableLocation();
+      await $.platformAutomator.android.enableLocation();
     }
 
     // Grant the location permission.
@@ -188,9 +188,9 @@ void main() {
 
     // Tap ok.
     if (Platform.isAndroid) {
-      await $.native.tap(Selector(text: "Got It"));
+      await $.platformAutomator.tap(Selector(text: "Got It"));
     } else if (Platform.isIOS) {
-      await $.native.tap(Selector(text: "OK"));
+      await $.platformAutomator.tap(Selector(text: "OK"));
     } else {
       fail('Unsupported platform: ${Platform.operatingSystem}');
     }

example/patrol_test/t03_navigation_test.dart

@@ -805,7 +805,7 @@ void main() {
 
       try {
         /// Cut network connection.
-        await $.native.enableAirplaneMode();
+        await $.platformAutomator.mobile.enableAirplaneMode();
 
         // Wait a while to ensure network is down.
         await $.tester.runAsync(
@@ -839,7 +839,7 @@ void main() {
         );
       } finally {
         /// Re-enable network connection.
-        await $.native.disableAirplaneMode();
+        await $.platformAutomator.mobile.disableAirplaneMode();
       }
     },
     // ATD emulator image used in Android CI does not have Settings app,

example/patrol_test/t06_map_test.dart

@@ -214,7 +214,7 @@ void main() {
         );
 
     /// Test that the onMapClicked event comes in.
-    await $.native.tapAt(const Offset(0.5, 0.5));
+    await $.platformAutomator.mobile.tapAt(const Offset(0.5, 0.5));
 
     /// Test the default values match with what has been documented in the
     /// API documentation in google_navigation_flutter.dart file.

example/patrol_test/t07_event_listener_test.dart

@@ -513,6 +513,7 @@ void main() {
       await $.pumpAndSettle();
 
       /// Set up GPS availability listeners with completers.
+      // ignore: deprecated_member_use
       void onGpsAvailability(GpsAvailabilityUpdatedEvent event) {
         $.log('GpsAvailabilityEvent (deprecated): $event');
         if (!gpsAvailabilityEventReceived.isCompleted) {
@@ -530,8 +531,11 @@ void main() {
       }
 
       /// Set up both the old (deprecated) and new gpsAvailability listeners.
+      // ignore: deprecated_member_use
       final StreamSubscription<GpsAvailabilityUpdatedEvent>
-      onGpsAvailabilitySubscription =
+          // ignore: deprecated_member_use
+          onGpsAvailabilitySubscription =
+          // ignore: deprecated_member_use
           await GoogleMapsNavigator.setOnGpsAvailabilityListener(
             onGpsAvailability,
           );
@@ -589,7 +593,7 @@ void main() {
       await $.pumpAndSettle();
 
       Future<void> cancelSubscriptionsAndResetState() async {
-        await $.native.enableLocation();
+        await $.platformAutomator.android.enableLocation();
         await onReroutingSubscription.cancel();
         await onGpsAvailabilitySubscription.cancel();
         await onGpsAvailabilityChangeSubscription.cancel();
@@ -604,7 +608,7 @@ void main() {
         },
       );
 
-      await $.native.disableLocation();
+      await $.platformAutomator.android.disableLocation();
 
       /// Wait for GPS availability events with timeout.
       await gpsAvailabilityEventReceived.future.timeout(

lib/src/types/terms_and_conditions_ui_params.dart

@@ -71,11 +71,11 @@ class TermsAndConditionsUIParams {
   /// for internal use with the platform channels.
   TermsAndConditionsUIParamsDto toDto() {
     return TermsAndConditionsUIParamsDto(
-      backgroundColor: backgroundColor?.value,
-      titleColor: titleColor?.value,
-      mainTextColor: mainTextColor?.value,
-      acceptButtonTextColor: acceptButtonTextColor?.value,
-      cancelButtonTextColor: cancelButtonTextColor?.value,
+      backgroundColor: backgroundColor?.toARGB32(),
+      titleColor: titleColor?.toARGB32(),
+      mainTextColor: mainTextColor?.toARGB32(),
+      acceptButtonTextColor: acceptButtonTextColor?.toARGB32(),
+      cancelButtonTextColor: cancelButtonTextColor?.toARGB32(),
     );
   }
 }