-
Notifications
You must be signed in to change notification settings - Fork 174
/
Copy pathBindingReceiverParameter.md.html
238 lines (205 loc) · 7.69 KB
/
BindingReceiverParameter.md.html
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
<meta charset="utf-8">
(#) @Binds/@Provides functions cannot be extensions
!!! ERROR: @Binds/@Provides functions cannot be extensions
This is an error.
Id
: `BindingReceiverParameter`
Summary
: @Binds/@Provides functions cannot be extensions
Severity
: Error
Category
: Correctness
Platform
: Any
Vendor
: slack
Identifier
: slack-lint
Contact
: https://github.com/slackhq/slack-lints
Feedback
: https://github.com/slackhq/slack-lints
Min
: Lint 8.0 and 8.1
Compiled
: Lint 8.0 and 8.1
Artifact
: [com.slack.lint:slack-lint-checks](com_slack_lint_slack-lint-checks.md.html)
Affects
: Kotlin and Java files and test sources
Editing
: This check runs on the fly in the IDE editor
Implementation
: [Source Code](https://github.com/slackhq/slack-lints/tree/main/slack-lint-checks/src/main/java/slack/lint/DaggerIssuesDetector.kt)
Tests
: [Source Code](https://github.com/slackhq/slack-lints/tree/main/slack-lint-checks/src/test/java/slack/lint/DaggerIssuesDetectorTest.kt)
Copyright Year
: 2021
@Binds/@Provides functions cannot be extension functions. Move the
receiver type to a parameter via IDE inspection (option+enter and
convert to parameter).
(##) Example
Here is an example of lint warnings produced by this check:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~text
src/foo/MyQualifier.kt:12:Error: @Binds/@Provides functions cannot be
extensions [BindingReceiverParameter]
@Binds fun Int.bind(): Number
---
src/foo/MyQualifier.kt:13:Error: @Binds/@Provides functions cannot be
extensions [BindingReceiverParameter]
@Binds fun Long.bind(): Number
----
src/foo/MyQualifier.kt:14:Error: @Binds/@Provides functions cannot be
extensions [BindingReceiverParameter]
@Binds fun Double.bind(): Number
------
src/foo/MyQualifier.kt:15:Error: @Binds/@Provides functions cannot be
extensions [BindingReceiverParameter]
@Binds fun Float.bind(): Number
-----
src/foo/MyQualifier.kt:16:Error: @Binds/@Provides functions cannot be
extensions [BindingReceiverParameter]
@Binds fun Short.bind(): Number
-----
src/foo/MyQualifier.kt:17:Error: @Binds/@Provides functions cannot be
extensions [BindingReceiverParameter]
@Binds fun Byte.bind(): Number
----
src/foo/MyQualifier.kt:18:Error: @Binds/@Provides functions cannot be
extensions [BindingReceiverParameter]
@Binds fun Char.bind(): Comparable<Char>
----
src/foo/MyQualifier.kt:19:Error: @Binds/@Provides functions cannot be
extensions [BindingReceiverParameter]
@Binds fun String.bind(): Comparable<String>
------
src/foo/MyQualifier.kt:20:Error: @Binds/@Provides functions cannot be
extensions [BindingReceiverParameter]
@Binds fun @receiver:MyQualifier Boolean.bind(): Comparable<Boolean>
-------
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Here is the source file referenced above:
`src/foo/MyQualifier.kt`:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~kotlin linenumbers
package foo
import javax.inject.Qualifier
import dagger.Binds
import dagger.Provides
import dagger.Module
@Qualifier
annotation class MyQualifier
@Module
interface MyModule {
@Binds fun Int.bind(): Number
@Binds fun Long.bind(): Number
@Binds fun Double.bind(): Number
@Binds fun Float.bind(): Number
@Binds fun Short.bind(): Number
@Binds fun Byte.bind(): Number
@Binds fun Char.bind(): Comparable<Char>
@Binds fun String.bind(): Comparable<String>
@Binds fun @receiver:MyQualifier Boolean.bind(): Comparable<Boolean>
}
@Module
interface MyModule2 {
@Provides fun Int.bind(): Number = this@bind
@Provides fun Long.bind(): Number = this@bind
@Provides fun Double.bind(): Number = this@bind
@Provides fun Float.bind(): Number = this@bind
@Provides fun Short.bind(): Number = this@bind
@Provides fun Byte.bind(): Number = this@bind
@Provides fun Char.bind(): Comparable<Char> = this@bind
@Provides fun String.bind(): Comparable<String> = this@bind
@Provides fun @receiver:MyQualifier Boolean.bind(): Comparable<Boolean> = this@bind
}
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
You can also visit the
[source code](https://github.com/slackhq/slack-lints/tree/main/slack-lint-checks/src/test/java/slack/lint/DaggerIssuesDetectorTest.kt)
for the unit tests for this check to see additional scenarios.
The above example was automatically extracted from the first unit test
found for this lint check, `DaggerIssuesDetector.bindings cannot be extension functions`.
To report a problem with this extracted sample, visit
https://github.com/slackhq/slack-lints.
(##) Including
!!!
This is not a built-in check. To include it, add the below dependency
to your project. This lint check is included in the lint documentation,
but the Android team may or may not agree with its recommendations.
```
// build.gradle.kts
lintChecks("com.slack.lint:slack-lint-checks:0.7.4")
// build.gradle
lintChecks 'com.slack.lint:slack-lint-checks:0.7.4'
// build.gradle.kts with version catalogs:
lintChecks(libs.slack.lint.checks)
# libs.versions.toml
[versions]
slack-lint-checks = "0.7.4"
[libraries]
# For clarity and text wrapping purposes the following declaration is
# shown split up across lines, but in TOML it needs to be on a single
# line (see https://github.com/toml-lang/toml/issues/516) so adjust
# when pasting into libs.versions.toml:
slack-lint-checks = {
module = "com.slack.lint:slack-lint-checks",
version.ref = "slack-lint-checks"
}
```
0.7.4 is the version this documentation was generated from;
there may be newer versions available.
[Additional details about com.slack.lint:slack-lint-checks](com_slack_lint_slack-lint-checks.md.html).
(##) Suppressing
You can suppress false positives using one of the following mechanisms:
* Using a suppression annotation like this on the enclosing
element:
```kt
// Kotlin
@Suppress("BindingReceiverParameter")
fun method() {
problematicStatement()
}
```
or
```java
// Java
@SuppressWarnings("BindingReceiverParameter")
void method() {
problematicStatement();
}
```
* Using a suppression comment like this on the line above:
```kt
//noinspection BindingReceiverParameter
problematicStatement()
```
* Using a special `lint.xml` file in the source tree which turns off
the check in that folder and any sub folder. A simple file might look
like this:
```xml
<?xml version="1.0" encoding="UTF-8"?>
<lint>
<issue id="BindingReceiverParameter" severity="ignore" />
</lint>
```
Instead of `ignore` you can also change the severity here, for
example from `error` to `warning`. You can find additional
documentation on how to filter issues by path, regular expression and
so on
[here](https://googlesamples.github.io/android-custom-lint-rules/usage/lintxml.md.html).
* In Gradle projects, using the DSL syntax to configure lint. For
example, you can use something like
```gradle
lintOptions {
disable 'BindingReceiverParameter'
}
```
In Android projects this should be nested inside an `android { }`
block.
* For manual invocations of `lint`, using the `--ignore` flag:
```
$ lint --ignore BindingReceiverParameter ...`
```
* Last, but not least, using baselines, as discussed
[here](https://googlesamples.github.io/android-custom-lint-rules/usage/baselines.md.html).
<!-- Markdeep: --><style class="fallback">body{visibility:hidden;white-space:pre;font-family:monospace}</style><script src="markdeep.min.js" charset="utf-8"></script><script src="https://morgan3d.github.io/markdeep/latest/markdeep.min.js" charset="utf-8"></script><script>window.alreadyProcessedMarkdeep||(document.body.style.visibility="visible")</script>