Skip to content

constructor detection for com.google.gson.Gson is working but tests unable to detect #96

Open
@theapache64

Description

@theapache64

Code: Modified avoid AvoidDateDetector.kt

override fun getApplicableConstructorTypes(): List<String> = listOf("com.google.gson.Gson")

  override fun visitConstructor(
    context: JavaContext,
    node: UCallExpression,
    constructor: PsiMethod,
  ) {
    context.report(
      ISSUE,
      node,
      context.getLocation(node),
      "Don't use `Gson`;",
    )
  }

Test

fun testDocumentationExample() {
    lint()
      .files(
        kotlin(
            """
              package test.pkg
              import com.google.gson.Gson
              fun test() {
                val gson = Gson()
              }
              """
          )
          .indented(),
      )
        .allowCompilationErrors()
      .run()
      .expectErrorCount(1)
  }

Result

  • ./gradlew lint is detecting this but test can't and the above test fails

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions