Address latest comments

Author: hamadise

apps-script/incident-response/ChatApi.gs

@@ -25,7 +25,6 @@
  * @return {string} The resource name of the new space.
  */
 function handleIncident(formData) {
-  console.log(formData)
   const isAppCredentials = formData.isAppCredentials; // Get the isAppCredentials element
   if(isAppCredentials){
     return handleIncidentWithAppCredentials(formData)

apps-script/incident-response/ChatApiAppCredentials.gs

@@ -27,30 +27,29 @@
  */
 function handleIncidentWithAppCredentials(formData) {
   const users = formData.users.trim().length > 0 ? formData.users.split(',') : [];
-  const service = _getService();
+  const service = getService_();
   if (!service.hasAccess()) {
       console.error(service.getLastError());
       return;
    }
-  const spaceName = _createChatSpaceWithAppCredentials(formData.title, service);
-  _createHumanMembershipWithAppCredentials(spaceName, getUserEmail(),service);
+  const spaceName = createChatSpaceWithAppCredentials_(formData.title, service);
+  createHumanMembershipWithAppCredentials_(spaceName, getUserEmail(),service);
   for (const user of users ){
-    _createHumanMembershipWithAppCredentials(spaceName, user, service);
+    createHumanMembershipWithAppCredentials_(spaceName, user, service);
   }
-  _createMessageWithAppCredentials(spaceName, formData.description, service);
+  createMessageWithAppCredentials_(spaceName, formData.description, service);
   return spaceName;
 }
-
 /**
  * Creates a chat space with application credentials.
  *
  * @param {string} displayName - The name of the chat space.
  * @param {object} service - The credentials of the service account.
  * @returns {string} The resource name of the new space.
- */
-function _createChatSpaceWithAppCredentials(displayName, service) {
+*/
+function createChatSpaceWithAppCredentials_(displayName, service) {
   try {
-    // for private apps, the alias can be used
+    // For private apps, the alias can be used
     const my_customer_alias = "customers/my_customer"
     // Specify the space to create.
     const space = {
@@ -64,23 +63,21 @@ function _createChatSpaceWithAppCredentials(displayName, service) {
         {},
         // Authenticate with the service account token.
         {'Authorization': 'Bearer ' + service.getAccessToken()});
-    // Log details about the created message.
-    console.log(createdSpace);
     return createdSpace.name;
   } catch (err) {
     // TODO (developer) - Handle exception.
     console.log('Failed to create space with error %s', err.message);
   }
 }
- /*
+/*
  * Creates a chat message with application credentials.
  *
  * @param {string} spaceName - The resource name of the space.
  * @param {string} message - The text to be posted.
  * @param {object} service - The credentials of the service account.
  * @return {string} the resource name of the new space.
  */
-function _createMessageWithAppCredentials(spaceName, message, service) {
+function createMessageWithAppCredentials_(spaceName, message, service) {
   try {
     const service = getService_();
     if (!service.hasAccess()) {
@@ -96,8 +93,6 @@ function _createMessageWithAppCredentials(spaceName, message, service) {
         // Authenticate with the service account token.
         {'Authorization': 'Bearer ' + service.getAccessToken()});
 
-    // Log details about the created message.
-    console.log(result);
   } catch (err) {
     // TODO (developer) - Handle exception.
     console.log('Failed to create message with error %s', err.message);
@@ -110,7 +105,7 @@ function _createMessageWithAppCredentials(spaceName, message, service) {
  * @param {string} email - The email of the user to be added.
  * @param {object} service - The credentials of the service account.
  */
-function _createHumanMembershipWithAppCredentials(spaceName, email, service){
+function createHumanMembershipWithAppCredentials_(spaceName, email, service){
   try{
     const service = getService_();
       if (!service.hasAccess()) {
@@ -130,7 +125,6 @@ function _createHumanMembershipWithAppCredentials(spaceName, email, service){
       {},
       {'Authorization': 'Bearer ' + service.getAccessToken()}
     );
-    console.log(result)
   } catch (err){
     console.log('Failed to create membership with error %s', err.message)
   }
@@ -141,7 +135,7 @@ function _createHumanMembershipWithAppCredentials(spaceName, email, service){
  * Creates a service for the service account.
  * @return {object}  - The credentials of the service account.
  */
-function _getService() {
+function getService_() {
   return OAuth2.createService(APP_CREDENTIALS.client_email)
       .setTokenUrl('https://oauth2.googleapis.com/token')
       .setPrivateKey(APP_CREDENTIALS.private_key)

apps-script/incident-response/ChatApiHumanCredentials.gs

@@ -27,9 +27,9 @@
  */
 function handleIncidentWithHumanCredentials(formData) {
   const users = formData.users.trim().length > 0 ? formData.users.split(',') : [];
-  const spaceName = _setUpSpaceWithHumanCredentials(formData.title, users);
-  _addAppToSpaceWithHumanCredentials(spaceName);
-  _createMessageWithHumanCredentials(spaceName, formData.description);
+  const spaceName = setUpSpaceWithHumanCredentials_(formData.title, users);
+  addAppToSpaceWithHumanCredentials_(spaceName);
+  createMessageWithHumanCredentials_(spaceName, formData.description);
   return spaceName;
 }
 
@@ -38,7 +38,7 @@ function handleIncidentWithHumanCredentials(formData) {
  *
  * @return {string} the resource name of the new space.
  */
-function _setUpSpaceWithHumanCredentials(displayName, users) {
+function setUpSpaceWithHumanCredentials_(displayName, users) {
   const memberships = users.map(email => ({
     member: {
       name: `users/${email}`,
@@ -63,7 +63,7 @@ function _setUpSpaceWithHumanCredentials(displayName, users) {
  *
  * @return {string} the resource name of the new membership.
  */
-function _addAppToSpaceWithHumanCredentials(spaceName) {
+function addAppToSpaceWithHumanCredentials_(spaceName) {
   const request = {
     member: {
       name: "users/app",
@@ -80,7 +80,7 @@ function _addAppToSpaceWithHumanCredentials(spaceName) {
  *
  * @return {string} the resource name of the new message.
  */
-function _createMessageWithHumanCredentials(spaceName, text) {
+function createMessageWithHumanCredentials_(spaceName, text) {
   const request = {
     text: text
   };

apps-script/incident-response/GeminiApi.gs

@@ -49,7 +49,9 @@ function summarizeChatHistory_(chatHistory) {
 
     if (responseCode === 200) {
       var json = JSON.parse(responseBody);
-      if (json.candidates && json.candidates.length > 0 && json.candidates[0].content && json.candidates[0].content.parts && json.candidates[0].content.parts.length > 0) {
+      if (json.candidates && json.candidates.length > 0 &&
+          json.candidates[0].content && json.candidates[0].content.parts &&
+          json.candidates[0].content.parts.length > 0) {
         return json.candidates[0].content.parts[0].text;
       } else {
         return "Gemini API: Unexpected response structure.";

apps-script/incident-response/README.md

@@ -138,64 +138,9 @@ Chat apps and Google Chat API requests](https://developers.devsite.corp.google.c
 
 #### 4.2 Set up authentication as an app
 
-This is available in [Developer Preview](/workspace/preview) only.
-
-##### 4.2.1 Setup service account and key
-
-1. In the Google Cloud console, go to **Menu*  > **IAM & Admin** > **Service Accounts**
-1. Click **Create service account**.
-1. Fill in the service account details, then click **Create and continue**.
-1. Click **Continue**
-1. Click **Done**. Make a note of the email address for the service account.
-1. Create private key:
-   1. In the Google Cloud console, go to **Menu** > **IAM & Admin** > **Service Accounts**.
-   [Go to Service Accounts]({{console_url}}iam-admin/serviceaccounts){:
-      class="button button-blue"
-      target="console"}
-   1. Select your service account.
-   1. Click **Keys** > **Add key** > **Create new key**.
-   1. Select **JSON**, then click **Create**.
-   1. Click **Close**.
-
-**Warning**: This example uses an exported service account key for simplicity's sake. Exporting a private key is not recommended 
-in production because it shouldn't be stored in an insecure location, such as source control. To learn more about secure service account 
-implementations and best practices, see Choose when to use service accounts.
-
-##### 4.2.2 Receive administrator approval
-
-To use an authorization scope that begins with
-`https://www.googleapis.com/auth/chat.app.*`, which are available as part of
-a Developer Preview, your Chat app must get a one-time
-[administrator approval](https://support.google.com/a?p=chat-app-auth).
-
-To use the `https://www.googleapis.com/auth/chat.bot` authorization scope,
-no administrator approval is required.
-
-To receive administrator approval, you must prepare your chat app's service account with the following
-information:
-
-* A Google Workspace Marketplace-compatible OAuth client
-* App configuration in the Google Workspace Marketplace SDK.
-
-1. In the Google Cloud console, go to **Menu**  > **IAM & Admin** > **Service Accounts**.
-1. Click the service account you created for your Chat app.
-1. Click **Advanced Setting**.
-1. Click **Create Google Workspace Marketplace-compatible OAuth client**.
-1. Click **Continue**.
-
-A confirmation message appears that says a Google Workspace Marketplace-compatible OAuth client has been created.
-After that, the Chap app should be configured in **Goolge Workspace Marketplace SDK**.
-
-1. In the Google Cloud console, enable the Google Workspace Marketplace SDK.
-1. In the Google Cloud console, go to go to **Menu** > **APIs & Services** > **Enabled APIs & services** > **Google Workspace Marketplace SDK** > **App Configuration**.
-1. Complete the App Configuration page. How you configure your Chat app depends on who your intended audience is and other factors. For help completing the app configuration page, see Configure your app in the Google Workspace Marketplace SDK. For the purposes of this guide, enter the following information:
-  1. Under **App visibility**, select **Private**
-  1. Under **Installation settings**, select **Individual + admin install**.
-  1. Under **App integrations**, select **Chat app**. 
-  1. Under **OAuth scopes**, enter all the scopes with ``https://www.googleapis.com/auth/chat.app.*``
-  1. Under **Developer information**, enter your **Developer name**, **Developer website URL**, and **Developer email**.
-  1. Click **Save draft**
-  1. [Set up authorization Chat app](https://support.google.com/a?p=chat-app-auth).
+This is available in [Developer Preview](/workspace/preview) only. 
+[The Google Chat app authentication]((https://developers.google.com/workspace/chat/authenticate-authorize-chat-app)) documentation provides details on how to set up authentication as an app.
+
 ### 5. Create an Apps Script project and connect it to the Google Cloud project
 
 Before creating the Apps Script project, copy your Google Cloud project number.