Address latest comments

Author: hamadise

apps-script/incident-response/ChatApi.gs

@@ -25,7 +25,6 @@
  * @return {string} The resource name of the new space.
  */
 function handleIncident(formData) {
-  console.log(formData)
   const isAppCredentials = formData.isAppCredentials; // Get the isAppCredentials element
   if(isAppCredentials){
     return handleIncidentWithAppCredentials(formData)

apps-script/incident-response/ChatApiAppCredentials.gs

@@ -27,30 +27,29 @@
  */
 function handleIncidentWithAppCredentials(formData) {
   const users = formData.users.trim().length > 0 ? formData.users.split(',') : [];
-  const service = _getService();
+  const service = getService_();
   if (!service.hasAccess()) {
       console.error(service.getLastError());
       return;
    }
-  const spaceName = _createChatSpaceWithAppCredentials(formData.title, service);
-  _createHumanMembershipWithAppCredentials(spaceName, getUserEmail(),service);
+  const spaceName = createChatSpaceWithAppCredentials_(formData.title, service);
+  createHumanMembershipWithAppCredentials_(spaceName, getUserEmail(),service);
   for (const user of users ){
-    _createHumanMembershipWithAppCredentials(spaceName, user, service);
+    createHumanMembershipWithAppCredentials_(spaceName, user, service);
   }
-  _createMessageWithAppCredentials(spaceName, formData.description, service);
+  createMessageWithAppCredentials_(spaceName, formData.description, service);
   return spaceName;
 }
-
 /**
  * Creates a chat space with application credentials.
  *
  * @param {string} displayName - The name of the chat space.
  * @param {object} service - The credentials of the service account.
  * @returns {string} The resource name of the new space.
- */
-function _createChatSpaceWithAppCredentials(displayName, service) {
+*/
+function createChatSpaceWithAppCredentials_(displayName, service) {
   try {
-    // for private apps, the alias can be used
+    // For private apps, the alias can be used
     const my_customer_alias = "customers/my_customer"
     // Specify the space to create.
     const space = {
@@ -64,23 +63,21 @@ function _createChatSpaceWithAppCredentials(displayName, service) {
         {},
         // Authenticate with the service account token.
         {'Authorization': 'Bearer ' + service.getAccessToken()});
-    // Log details about the created message.
-    console.log(createdSpace);
     return createdSpace.name;
   } catch (err) {
     // TODO (developer) - Handle exception.
     console.log('Failed to create space with error %s', err.message);
   }
 }
- /*
+/*
  * Creates a chat message with application credentials.
  *
  * @param {string} spaceName - The resource name of the space.
  * @param {string} message - The text to be posted.
  * @param {object} service - The credentials of the service account.
  * @return {string} the resource name of the new space.
  */
-function _createMessageWithAppCredentials(spaceName, message, service) {
+function createMessageWithAppCredentials_(spaceName, message, service) {
   try {
     const service = getService_();
     if (!service.hasAccess()) {
@@ -96,8 +93,6 @@ function _createMessageWithAppCredentials(spaceName, message, service) {
         // Authenticate with the service account token.
         {'Authorization': 'Bearer ' + service.getAccessToken()});
 
-    // Log details about the created message.
-    console.log(result);
   } catch (err) {
     // TODO (developer) - Handle exception.
     console.log('Failed to create message with error %s', err.message);
@@ -110,7 +105,7 @@ function _createMessageWithAppCredentials(spaceName, message, service) {
  * @param {string} email - The email of the user to be added.
  * @param {object} service - The credentials of the service account.
  */
-function _createHumanMembershipWithAppCredentials(spaceName, email, service){
+function createHumanMembershipWithAppCredentials_(spaceName, email, service){
   try{
     const service = getService_();
       if (!service.hasAccess()) {
@@ -130,7 +125,6 @@ function _createHumanMembershipWithAppCredentials(spaceName, email, service){
       {},
       {'Authorization': 'Bearer ' + service.getAccessToken()}
     );
-    console.log(result)
   } catch (err){
     console.log('Failed to create membership with error %s', err.message)
   }
@@ -141,7 +135,7 @@ function _createHumanMembershipWithAppCredentials(spaceName, email, service){
  * Creates a service for the service account.
  * @return {object}  - The credentials of the service account.
  */
-function _getService() {
+function getService_() {
   return OAuth2.createService(APP_CREDENTIALS.client_email)
       .setTokenUrl('https://oauth2.googleapis.com/token')
       .setPrivateKey(APP_CREDENTIALS.private_key)

apps-script/incident-response/ChatApiHumanCredentials.gs

@@ -27,9 +27,9 @@
  */
 function handleIncidentWithHumanCredentials(formData) {
   const users = formData.users.trim().length > 0 ? formData.users.split(',') : [];
-  const spaceName = _setUpSpaceWithHumanCredentials(formData.title, users);
-  _addAppToSpaceWithHumanCredentials(spaceName);
-  _createMessageWithHumanCredentials(spaceName, formData.description);
+  const spaceName = setUpSpaceWithHumanCredentials_(formData.title, users);
+  addAppToSpaceWithHumanCredentials_(spaceName);
+  createMessageWithHumanCredentials_(spaceName, formData.description);
   return spaceName;
 }
 
@@ -38,7 +38,7 @@ function handleIncidentWithHumanCredentials(formData) {
  *
  * @return {string} the resource name of the new space.
  */
-function _setUpSpaceWithHumanCredentials(displayName, users) {
+function setUpSpaceWithHumanCredentials_(displayName, users) {
   const memberships = users.map(email => ({
     member: {
       name: `users/${email}`,
@@ -63,7 +63,7 @@ function _setUpSpaceWithHumanCredentials(displayName, users) {
  *
  * @return {string} the resource name of the new membership.
  */
-function _addAppToSpaceWithHumanCredentials(spaceName) {
+function addAppToSpaceWithHumanCredentials_(spaceName) {
   const request = {
     member: {
       name: "users/app",
@@ -80,7 +80,7 @@ function _addAppToSpaceWithHumanCredentials(spaceName) {
  *
  * @return {string} the resource name of the new message.
  */
-function _createMessageWithHumanCredentials(spaceName, text) {
+function createMessageWithHumanCredentials_(spaceName, text) {
   const request = {
     text: text
   };

apps-script/incident-response/GeminiApi.gs

@@ -49,7 +49,9 @@ function summarizeChatHistory_(chatHistory) {
 
     if (responseCode === 200) {
       var json = JSON.parse(responseBody);
-      if (json.candidates && json.candidates.length > 0 && json.candidates[0].content && json.candidates[0].content.parts && json.candidates[0].content.parts.length > 0) {
+      if (json.candidates && json.candidates.length > 0 &&
+          json.candidates[0].content && json.candidates[0].content.parts &&
+          json.candidates[0].content.parts.length > 0) {
         return json.candidates[0].content.parts[0].text;
       } else {
         return "Gemini API: Unexpected response structure.";