Skip to content

Commit 97565ab

Browse files
committed
Migrating the path Migrating the gsutil usage to gcloud storage
1 parent 80dad8e commit 97565ab

File tree

8 files changed

+32
-31
lines changed

8 files changed

+32
-31
lines changed

config/samples/resources/cloudbuildtrigger/build-trigger-for-cloud-source-repo/cloudbuild_v1beta1_cloudbuildtrigger.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ spec:
3939
timeout: 1800s
4040
step:
4141
- id: "download_zip"
42-
name: gcr.io/cloud-builders/gsutil
43-
args: ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
42+
name: gcr.io/cloud-builders/gcloud
43+
args: ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
4444
timeout: 300s
4545
- id: "build_package"
4646
name: gcr.io/cloud-builders/go

config/samples/resources/cloudbuildtrigger/build-trigger-for-github-repo/cloudbuild_v1beta1_cloudbuildtrigger.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,9 @@ spec:
4242
timeout: 1800s
4343
step:
4444
- id: "download_zip"
45-
name: gcr.io/cloud-builders/gsutil
46-
args: ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
45+
name: gcr.io/cloud-builders/gcloud
46+
entrypoint: gcloud
47+
args: ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
4748
timeout: 300s
4849
- id: "build_package"
4950
name: gcr.io/cloud-builders/go

operator/scripts/utils/cmd.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func DownloadAndExtractTarballAt(gcsPath, outputDir string) error {
3939
}
4040

4141
func DownloadObjectFromGCS(gcsPath, outputDir string) error {
42-
cmd := exec.Command("gsutil", "cp", gcsPath, outputDir)
42+
cmd := exec.Command("gcloud", "storage", "cp", gcsPath, outputDir)
4343
return Execute(cmd)
4444
}
4545

pkg/test/resourcefixture/testdata/basic/cloudbuild/v1beta1/cloudbuildtrigger/cloudbuildtrigger/create.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ spec:
3737
timeout: 1800s
3838
step:
3939
- id: "download_zip"
40-
name: gcr.io/cloud-builders/gsutil
41-
args: ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
40+
name: gcr.io/cloud-builders/gcloud
41+
args: ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
4242
timeout: 300s
4343
- id: "build_package"
4444
name: gcr.io/cloud-builders/go

pkg/test/resourcefixture/testdata/basic/cloudbuild/v1beta1/cloudbuildtrigger/cloudbuildtrigger/update.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ spec:
3737
timeout: 1800s
3838
step:
3939
- id: "download_zip"
40-
name: gcr.io/cloud-builders/gsutil
41-
args: ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
40+
name: gcr.io/cloud-builders/gcloud
41+
args: ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
4242
timeout: 300s
4343
- id: "build_package"
4444
name: gcr.io/cloud-builders/go

third_party/github.com/hashicorp/terraform-provider-google-beta/google-beta/services/cloudbuild/resource_cloudbuild_trigger_generated_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ resource "google_cloudbuild_trigger" "build-trigger" {
113113
114114
build {
115115
step {
116-
name = "gcr.io/cloud-builders/gsutil"
117-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
116+
name = "gcr.io/cloud-builders/gcloud"
117+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
118118
timeout = "120s"
119119
secret_env = ["MY_SECRET"]
120120
}

third_party/github.com/hashicorp/terraform-provider-google-beta/google-beta/services/cloudbuild/resource_cloudbuild_trigger_test.go

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,8 @@ resource "google_cloudbuild_trigger" "build_trigger" {
247247
tags = ["team-a", "service-b"]
248248
timeout = "1800s"
249249
step {
250-
name = "gcr.io/cloud-builders/gsutil"
251-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
250+
name = "gcr.io/cloud-builders/gcloud"
251+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
252252
timeout = "300s"
253253
}
254254
step {
@@ -325,8 +325,8 @@ resource "google_cloudbuild_trigger" "build_trigger" {
325325
images = ["gcr.io/$PROJECT_ID/$REPO_NAME:$COMMIT_SHA"]
326326
tags = ["team-a", "service-b"]
327327
step {
328-
name = "gcr.io/cloud-builders/gsutil"
329-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
328+
name = "gcr.io/cloud-builders/gcloud"
329+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
330330
}
331331
step {
332332
name = "gcr.io/cloud-builders/go"
@@ -384,8 +384,8 @@ resource "google_cloudbuild_trigger" "build_trigger" {
384384
tags = ["team-a", "service-b", "updated"]
385385
timeout = "2100s"
386386
step {
387-
name = "gcr.io/cloud-builders/gsutil"
388-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile-updated.zip"]
387+
name = "gcr.io/cloud-builders/gcloud"
388+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile-updated.zip"]
389389
timeout = "300s"
390390
}
391391
step {
@@ -426,8 +426,8 @@ resource "google_cloudbuild_trigger" "build_trigger" {
426426
tags = ["team-a", "service-b"]
427427
timeout = "1800s"
428428
step {
429-
name = "gcr.io/cloud-builders/gsutil"
430-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
429+
name = "gcr.io/cloud-builders/gcloud"
430+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
431431
timeout = "300s"
432432
}
433433
available_secrets {
@@ -454,8 +454,8 @@ resource "google_cloudbuild_trigger" "build_trigger" {
454454
tags = ["team-a", "service-b"]
455455
timeout = "1800s"
456456
step {
457-
name = "gcr.io/cloud-builders/gsutil"
458-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
457+
name = "gcr.io/cloud-builders/gcloud"
458+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
459459
timeout = "300s"
460460
}
461461
}
@@ -479,8 +479,8 @@ resource "google_cloudbuild_trigger" "build_trigger" {
479479
tags = ["team-a", "service-b"]
480480
timeout = "1800s"
481481
step {
482-
name = "gcr.io/cloud-builders/gsutil"
483-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
482+
name = "gcr.io/cloud-builders/gcloud"
483+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
484484
timeout = "300s"
485485
}
486486
}
@@ -507,8 +507,8 @@ resource "google_cloudbuild_trigger" "build_trigger" {
507507
tags = ["team-a", "service-b"]
508508
timeout = "1800s"
509509
step {
510-
name = "gcr.io/cloud-builders/gsutil"
511-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
510+
name = "gcr.io/cloud-builders/gcloud"
511+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
512512
timeout = "300s"
513513
}
514514
}
@@ -663,8 +663,8 @@ resource "google_cloudbuild_trigger" "build_trigger" {
663663
tags = ["team-a", "service-b"]
664664
timeout = "900s"
665665
step {
666-
name = "gcr.io/cloud-builders/gsutil"
667-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
666+
name = "gcr.io/cloud-builders/gcloud"
667+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
668668
timeout = "500s"
669669
}
670670
step {
@@ -697,8 +697,8 @@ resource "google_cloudbuild_trigger" "build_trigger" {
697697
tags = ["team-a", "service-b"]
698698
timeout = "1200"
699699
step {
700-
name = "gcr.io/cloud-builders/gsutil"
701-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
700+
name = "gcr.io/cloud-builders/gcloud"
701+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile.zip"]
702702
timeout = "500s"
703703
}
704704
}

third_party/github.com/hashicorp/terraform-provider-google-beta/website/docs/guides/version_2_upgrade.html.markdown

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,8 +300,8 @@ resource "google_cloudbuild_trigger" "build_trigger" {
300300
tags = ["team-a", "service-b", "updated"]
301301
302302
step {
303-
name = "gcr.io/cloud-builders/gsutil"
304-
args = ["cp", "gs://mybucket/remotefile.zip", "localfile-updated.zip"]
303+
name = "gcr.io/cloud-builders/gcloud"
304+
args = ["storage", "cp", "gs://mybucket/remotefile.zip", "localfile-updated.zip"]
305305
}
306306
307307
step {

0 commit comments

Comments
 (0)