Skip to content

Commit d9d7d8c

Browse files
authored
Merge pull request #2287 from goplus/main
rm dep of golang.org/x/tools
2 parents ea2b912 + eef3290 commit d9d7d8c

File tree

5 files changed

+8
-30
lines changed

5 files changed

+8
-30
lines changed

.github/workflows/go.yml

+1-6
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
- 1.19.x
3030
- 1.21.x
3131
- 1.22.x
32-
- 1.23.x
32+
- 1.24.x
3333
runs-on: ${{ matrix.os }}
3434
steps:
3535
- uses: actions/checkout@v4
@@ -72,11 +72,6 @@ jobs:
7272
with:
7373
go-version: ${{ matrix.go }}
7474

75-
- name: Update golang.org/x/tools
76-
run: |
77-
go work init .
78-
go work edit -replace golang.org/x/tools=golang.org/x/[email protected]
79-
8075
- name: Test Go+ installer
8176
run: |
8277
git config --global user.email "[email protected]"

cl/outline/outline.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ import (
2121
"strings"
2222

2323
"github.com/goplus/gogen"
24+
"github.com/goplus/gogen/typeutil"
2425
"github.com/goplus/gop/ast"
2526
"github.com/goplus/gop/cl"
2627
"github.com/goplus/gop/token"
2728
"github.com/goplus/mod/modfile"
28-
"golang.org/x/tools/go/types/typeutil"
2929
)
3030

3131
// -----------------------------------------------------------------------------

cmd/make.go

-13
Original file line numberDiff line numberDiff line change
@@ -351,13 +351,6 @@ func buildGoplusTools(useGoProxy bool) {
351351
log.Fatalln(err)
352352
}
353353

354-
switch goVersion() {
355-
case "1.24":
356-
work := filepath.Join(commandsDir, "_make", "1.24", "go.work")
357-
commandExecuteEnv = append(commandExecuteEnv,
358-
"GOWORK="+work)
359-
}
360-
361354
println("Building Go+ tools...\n")
362355
os.Chdir(commandsDir)
363356
buildOutput, err := execCommand("go", "build", "-o", gopBinPath, "-v", "-ldflags", buildFlags, "./...")
@@ -372,12 +365,6 @@ func buildGoplusTools(useGoProxy bool) {
372365
println("\nGo+ tools built successfully!")
373366
}
374367

375-
var (
376-
workfile = `use ./..
377-
replace golang.org/x/tools => golang.org/x/tools v0.30
378-
`
379-
)
380-
381368
func goVersion() string {
382369
out, err := execCommand("go", "version")
383370
if err != nil {

go.mod

+2-3
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ go 1.18
44

55
require (
66
github.com/fsnotify/fsnotify v1.9.0
7-
github.com/goplus/gogen v1.16.9
7+
github.com/goplus/gogen v1.17.1
88
github.com/goplus/llgo v0.10.1
9-
github.com/goplus/mod v0.15.0
9+
github.com/goplus/mod v0.15.1
1010
github.com/qiniu/x v1.13.17
11-
golang.org/x/tools v0.19.0
1211
)
1312

1413
require (

go.sum

+4-7
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,14 @@
11
github.com/fsnotify/fsnotify v1.9.0 h1:2Ml+OJNzbYCTzsxtv8vKSFD9PbJjmhYF14k/jKC7S9k=
22
github.com/fsnotify/fsnotify v1.9.0/go.mod h1:8jBTzvmWwFyi3Pb8djgCCO5IBqzKJ/Jwo8TRcHyHii0=
3-
github.com/goplus/gogen v1.16.9 h1:BRNAsRzdyMcLBOLUe6+suVMmOe+D2HLfF7mAkS4/QW4=
4-
github.com/goplus/gogen v1.16.9/go.mod h1:6TQYbabXDF9LCdDkOOzHmfg1R4ENfXQ3XpHa9RhTSD8=
3+
github.com/goplus/gogen v1.17.1 h1:dx1KoggI3jK0ti4GyQAJMPAib81BP2uePA8xQ9dMJlU=
4+
github.com/goplus/gogen v1.17.1/go.mod h1:owX2e1EyU5WD+Nm6oH2m/GXjLdlBYcwkLO4wN8HHXZI=
55
github.com/goplus/llgo v0.10.1 h1:Cla7Rv6S67SnAknMm8nNvHhxFf9Fo/daHRcs3w3rS6s=
66
github.com/goplus/llgo v0.10.1/go.mod h1:YfOHsT/g3lc9b4GclLj812YzdSsJr0kd3CCB830TqHE=
7-
github.com/goplus/mod v0.15.0 h1:EPQVii2PpEq6JRfHw9zxEu1/aoJbzSDTSQO5nNPsBDA=
8-
github.com/goplus/mod v0.15.0/go.mod h1:TaeZAljI1qWHNh27w5lSLIhhMvPSihr6sQu7Lnp/2aE=
7+
github.com/goplus/mod v0.15.1 h1:kNSnM5ZIpZbZmySzv/oqK9uJF5RCxRvcLsxjDMOxWVw=
8+
github.com/goplus/mod v0.15.1/go.mod h1:ww47rwm4lzsqZN8Oz5jH8wt/KsQclltMe45DelLJmSA=
99
github.com/qiniu/x v1.13.17 h1:x5GJNg3rN2PagEZ5JvXmusoIaK1iaGGppFK41i0VAis=
1010
github.com/qiniu/x v1.13.17/go.mod h1:AiovSOCaRijaf3fj+0CBOpR1457pn24b0Vdb1JpwhII=
1111
golang.org/x/mod v0.20.0 h1:utOm6MM3R3dnawAiJgn0y+xvuYRsm1RKM/4giyfDgV0=
1212
golang.org/x/mod v0.20.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
13-
golang.org/x/sync v0.6.0 h1:5BMeUDZ7vkXGfEr1x9B4bRcTH4lpkTkpdh0T/J+qjbQ=
1413
golang.org/x/sys v0.21.0 h1:rF+pYz3DAGSQAxAu1CbC7catZg4ebC4UIeIhKxBZvws=
1514
golang.org/x/sys v0.21.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
16-
golang.org/x/tools v0.19.0 h1:tfGCXNR1OsFG+sVdLAitlpjAvD/I6dHDKnYrpEZUHkw=
17-
golang.org/x/tools v0.19.0/go.mod h1:qoJWxmGSIBmAeriMx19ogtrEPrGtDbPK634QFIcLAhc=

0 commit comments

Comments
 (0)